linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion
Date: Mon, 18 May 2015 11:44:24 +0100	[thread overview]
Message-ID: <5559C288.7020703@arm.com> (raw)
In-Reply-To: <20150518104223.GT2067@n2100.arm.linux.org.uk>


On 18/05/15 11:42, Russell King - ARM Linux wrote:
> On Thu, Apr 30, 2015 at 03:19:01PM +0100, Sudeep Holla wrote:
>>
>>
>> On 30/04/15 15:09, Rob Herring wrote:
>>> On Thu, Apr 30, 2015 at 5:44 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>>> The header asm/hardware/arm_timer.h is included in various machine
>>>> specific files to access TIMER_CTRL and initialise to a known state.
>>>> However that's not required as the clock{source,event} driver timer-sp
>>>> initialises all the timer being used.
>>>
>>> I believe the idea is not to initialize the timers being used, but the
>>> ones not being used and perhaps left running by the bootloader. Cases
>>> where the interrupt is shared could cause a problem.
>>>
>>
>> Ah OK, makes sense. I will wait for Russell to confirm. The main idea
>> was to keep the header file having offsets local to driver/clocksource
>> and avoid sharing it in include/linux but looks like that's not possible.
>
> An alternative would be to have a new function, something like
> sp804_disable() which takes the virtual address of the timer.
> That'd still allow the platforms to disable all timers, but
> without exposing the register stuff to them.
>

Yes that's much better, will re-spin the patch accordingly.

Regards,
Sudeep

  reply	other threads:[~2015-05-18 10:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 10:44 [PATCH 0/2] ARM: move Dual-Timer SP804 driver to drivers/clocksource Sudeep Holla
2015-04-30 10:44 ` [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion Sudeep Holla
2015-04-30 14:09   ` Rob Herring
2015-04-30 14:19     ` Sudeep Holla
2015-05-15 18:03       ` Sudeep Holla
2015-05-18 10:33         ` Catalin Marinas
2015-05-18 10:38           ` Sudeep Holla
2015-05-18 10:42       ` Russell King - ARM Linux
2015-05-18 10:44         ` Sudeep Holla [this message]
2015-05-18 10:40     ` Russell King - ARM Linux
2015-05-18 10:43       ` Sudeep Holla
2015-04-30 10:44 ` [PATCH 2/2] ARM: move Dual-Timer SP804 driver to drivers/clocksource Sudeep Holla
2015-05-18 12:44 ` [PATCH v2 0/2] " Sudeep Holla
2015-05-18 12:44   ` [PATCH v2 1/2] ARM: introduce sp804_timer_disable and remove arm_timer.h inclusion Sudeep Holla
2015-05-18 12:44   ` [PATCH v2 2/2] ARM: move Dual-Timer SP804 driver to drivers/clocksource Sudeep Holla
2015-05-18 13:47   ` [PATCH v2 0/2] " Russell King - ARM Linux
2015-05-18 14:05     ` Sudeep Holla
2015-05-18 14:34   ` Thomas Gleixner
2015-05-18 15:32     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5559C288.7020703@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).