From: acourbot@nvidia.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/nouveau/platform: add IOMMU dependency
Date: Wed, 20 May 2015 09:33:46 +0900 [thread overview]
Message-ID: <555BD66A.5020704@nvidia.com> (raw)
In-Reply-To: <2918377.0irYYn09PU@wuerfel>
On 05/19/2015 09:53 PM, Arnd Bergmann wrote:
> The recently added iommu code in the nouveau driver fails to build
> when the IOMMU support is disabled:
>
> drivers/gpu/drm/nouveau/nouveau_platform.c: In function 'nouveau_platform_probe_iommu':
> drivers/gpu/drm/nouveau/nouveau_platform.c:113:41: error: 'const struct iommu_ops' has no mem
>
> To avoid the build error, this now adds an explicit dependency on the
> IOMMU implementation.
I have a local patch to nouveau_platform.c that only calls the IOMMU
functions if CONFIG_IOMMU is set. Wouldn't this be more suitable as
IOMMU support is only used by Tegra and thus not beneficial for desktop
GPUs?
next prev parent reply other threads:[~2015-05-20 0:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 12:53 [PATCH] drm/nouveau/platform: add IOMMU dependency Arnd Bergmann
2015-05-19 13:32 ` Thierry Reding
2015-05-20 0:33 ` Alexandre Courbot [this message]
2015-05-20 6:10 ` [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU Alexandre Courbot
2015-05-20 7:07 ` Arnd Bergmann
2015-05-26 8:43 ` Alexandre Courbot
2015-05-20 11:32 ` Thierry Reding
2015-05-20 12:01 ` Arnd Bergmann
2015-05-20 14:18 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555BD66A.5020704@nvidia.com \
--to=acourbot@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).