From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
Date: Wed, 27 May 2015 14:33:59 +0200 [thread overview]
Message-ID: <5565B9B7.8080506@xilinx.com> (raw)
In-Reply-To: <1432582863-5012-1-git-send-email-shailendra.capricorn@gmail.com>
+Greg
On 05/25/2015 09:41 PM, Shailendra Verma wrote:
> The variable dirty is bool type. Hence assign the variable with
> bool value true/false instead of 1/0.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> index 05d8977..53c3882 100644
> --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> int status;
> s32 buffer_count = 0;
> s32 num_writes = 0;
> - bool dirty = 0;
> + bool dirty = false;
> u32 i;
> void __iomem *base_address = drvdata->base_address;
>
> @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> /* Copy data to bram */
> buffer_icap_set_bram(base_address, buffer_count, data[i]);
> - dirty = 1;
> + dirty = true;
>
> if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> buffer_count++;
> @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> buffer_count = 0;
> num_writes++;
> - dirty = 0;
> + dirty = false;
> }
>
> /* Write unwritten data to ICAP */
>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
next prev parent reply other threads:[~2015-05-27 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 19:41 [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration() Shailendra Verma
2015-05-27 12:33 ` Michal Simek [this message]
2015-05-31 3:23 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-06-02 6:40 Michal Simek
2015-06-02 16:52 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565B9B7.8080506@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).