* [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
@ 2015-05-25 19:41 Shailendra Verma
2015-05-27 12:33 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Shailendra Verma @ 2015-05-25 19:41 UTC (permalink / raw)
To: linux-arm-kernel
The variable dirty is bool type. Hence assign the variable with
bool value true/false instead of 1/0.
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
index 05d8977..53c3882 100644
--- a/drivers/char/xilinx_hwicap/buffer_icap.c
+++ b/drivers/char/xilinx_hwicap/buffer_icap.c
@@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
int status;
s32 buffer_count = 0;
s32 num_writes = 0;
- bool dirty = 0;
+ bool dirty = false;
u32 i;
void __iomem *base_address = drvdata->base_address;
@@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
/* Copy data to bram */
buffer_icap_set_bram(base_address, buffer_count, data[i]);
- dirty = 1;
+ dirty = true;
if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
buffer_count++;
@@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
buffer_count = 0;
num_writes++;
- dirty = 0;
+ dirty = false;
}
/* Write unwritten data to ICAP */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
2015-05-25 19:41 [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration() Shailendra Verma
@ 2015-05-27 12:33 ` Michal Simek
2015-05-31 3:23 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2015-05-27 12:33 UTC (permalink / raw)
To: linux-arm-kernel
+Greg
On 05/25/2015 09:41 PM, Shailendra Verma wrote:
> The variable dirty is bool type. Hence assign the variable with
> bool value true/false instead of 1/0.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> index 05d8977..53c3882 100644
> --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> int status;
> s32 buffer_count = 0;
> s32 num_writes = 0;
> - bool dirty = 0;
> + bool dirty = false;
> u32 i;
> void __iomem *base_address = drvdata->base_address;
>
> @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> /* Copy data to bram */
> buffer_icap_set_bram(base_address, buffer_count, data[i]);
> - dirty = 1;
> + dirty = true;
>
> if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> buffer_count++;
> @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> buffer_count = 0;
> num_writes++;
> - dirty = 0;
> + dirty = false;
> }
>
> /* Write unwritten data to ICAP */
>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
2015-05-27 12:33 ` Michal Simek
@ 2015-05-31 3:23 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-05-31 3:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 27, 2015 at 02:33:59PM +0200, Michal Simek wrote:
> +Greg
>
> On 05/25/2015 09:41 PM, Shailendra Verma wrote:
> > The variable dirty is bool type. Hence assign the variable with
> > bool value true/false instead of 1/0.
> >
> > Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> > ---
> > drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> > index 05d8977..53c3882 100644
> > --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> > +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> > @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> > int status;
> > s32 buffer_count = 0;
> > s32 num_writes = 0;
> > - bool dirty = 0;
> > + bool dirty = false;
> > u32 i;
> > void __iomem *base_address = drvdata->base_address;
> >
> > @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> >
> > /* Copy data to bram */
> > buffer_icap_set_bram(base_address, buffer_count, data[i]);
> > - dirty = 1;
> > + dirty = true;
> >
> > if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> > buffer_count++;
> > @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> >
> > buffer_count = 0;
> > num_writes++;
> > - dirty = 0;
> > + dirty = false;
> > }
> >
> > /* Write unwritten data to ICAP */
> >
>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
Hm, I don't have the original, can you resend it with your tested-by?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
@ 2015-06-02 6:40 Michal Simek
2015-06-02 16:52 ` Moritz Fischer
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2015-06-02 6:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Shailendra Verma <shailendra.capricorn@gmail.com>
The variable dirty is bool type. Hence assign the variable with
bool value true/false instead of 1/0.
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
Tested-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
index 05d897764f02..53c3882e4981 100644
--- a/drivers/char/xilinx_hwicap/buffer_icap.c
+++ b/drivers/char/xilinx_hwicap/buffer_icap.c
@@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
int status;
s32 buffer_count = 0;
s32 num_writes = 0;
- bool dirty = 0;
+ bool dirty = false;
u32 i;
void __iomem *base_address = drvdata->base_address;
@@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
/* Copy data to bram */
buffer_icap_set_bram(base_address, buffer_count, data[i]);
- dirty = 1;
+ dirty = true;
if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
buffer_count++;
@@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
buffer_count = 0;
num_writes++;
- dirty = 0;
+ dirty = false;
}
/* Write unwritten data to ICAP */
--
2.3.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
2015-06-02 6:40 Michal Simek
@ 2015-06-02 16:52 ` Moritz Fischer
0 siblings, 0 replies; 5+ messages in thread
From: Moritz Fischer @ 2015-06-02 16:52 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 1, 2015 at 11:40 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Shailendra Verma <shailendra.capricorn@gmail.com>
>
> The variable dirty is bool type. Hence assign the variable with
> bool value true/false instead of 1/0.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
Feel free to add:
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>
> drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> index 05d897764f02..53c3882e4981 100644
> --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> int status;
> s32 buffer_count = 0;
> s32 num_writes = 0;
> - bool dirty = 0;
> + bool dirty = false;
> u32 i;
> void __iomem *base_address = drvdata->base_address;
>
> @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> /* Copy data to bram */
> buffer_icap_set_bram(base_address, buffer_count, data[i]);
> - dirty = 1;
> + dirty = true;
>
> if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> buffer_count++;
> @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> buffer_count = 0;
> num_writes++;
> - dirty = 0;
> + dirty = false;
> }
>
> /* Write unwritten data to ICAP */
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-02 16:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 19:41 [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration() Shailendra Verma
2015-05-27 12:33 ` Michal Simek
2015-05-31 3:23 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-06-02 6:40 Michal Simek
2015-06-02 16:52 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).