From mboxrd@z Thu Jan 1 00:00:00 1970 From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath) Date: Thu, 28 May 2015 18:59:21 +0530 Subject: [PATCH 08/12] i2c: pxa: enable/disable irq across message xfer In-Reply-To: <20150528131707.GB2067@n2100.arm.linux.org.uk> References: <1432818224-17070-1-git-send-email-vaibhav.hiremath@linaro.org> <1432818224-17070-9-git-send-email-vaibhav.hiremath@linaro.org> <20150528131707.GB2067@n2100.arm.linux.org.uk> Message-ID: <55671831.7010903@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 28 May 2015 06:47 PM, Russell King - ARM Linux wrote: > On Thu, May 28, 2015 at 06:33:40PM +0530, Vaibhav Hiremath wrote: >> In order to avoid "spurious irq" caused by CP polling mode, >> enable irq at the entry of i2c_pxa_xfer() fn and disable it >> again before exit. > > NAK. > > It's really not nice for drivers to disable a potentially shared interrupt. > If the interrupt is shared, you disable the interrupt for other users of > that interrupt as well. See: > > commit c66dc529194be374556d166ee7ddb84a7d1d302b > Author: Sebastian Andrzej Siewior > Date: Wed Feb 23 12:38:18 2011 +0100 > > i2c-pxa2xx: add support for shared IRQ handler > > Sodaville has three of them on a single IRQ. IRQF_DISABLED is removed > because it is a NOP allready and scheduled for removal. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Dirk Brandewie > Signed-off-by: Ben Dooks > > So you're breaking Sodaville. > Got it. I will drop this patch from the series. Before submitting next version, will wait for review on other patches. Thanks, Vaibhav