From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD00C433E0 for ; Tue, 12 Jan 2021 10:11:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 732DF23107 for ; Tue, 12 Jan 2021 10:11:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 732DF23107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EIzTb91xOh8mLWuswt/AhkPTLv/UAZf3jXgw0HDB0Bc=; b=woMssPOgartcXzxwuL9XWm3U6 XMbX44XwWUK7dvFTmo43oojXK//S9gqCOyBdaMGYQo+o5x6YoZvVuxM/DS+6NIf4lTkZTucTt7Tgp D6vcwGyoSmAoNxDjTq4KxKBTMwWBzTmF2DI+u5v877i8Q4Letrm+lT3GAiSJweTTmnyeJ0wzEOAss /dh2UkU7PKQRj1/eNRksS0nfqPREZRo6lDqleCMATi8roc8+s86a9YCLT4L8TdIA9Q64X0Epnb18o DGFsBQ5YNreQrqn0N8kPrvBdBvBJe7ZxElJfLJ5XAY83CLbKACXSms4H+PJKSdwXvk/FV9m5QWMrm lV8weKA6w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzGcV-0006Wh-6z; Tue, 12 Jan 2021 10:09:47 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzGcR-0006VR-4Z for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 10:09:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610446182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DOMRwNgT9qr+9pqPfBttykBmS2K+2o6KQydrMDGzqpk=; b=i5xCGUx7XBGmh2ZghUR0lXrHA9zZIDa8pJe66YNEP5yzkSFg1TNQNh1vsGEvLESW3bad0Z VX7ODY5jKqPQOWhLqUE3v02KjMWqlvVI2sDeyotm0EM+TmFuMxZp9XgXPTWrRNFqIyXubT no/bCFxYqn1Bk9Zi7W8lxDvJ2lbcUQc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-Bi2gpNL4Orq9i6DussAoYA-1; Tue, 12 Jan 2021 05:09:40 -0500 X-MC-Unique: Bi2gpNL4Orq9i6DussAoYA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB2C31800D42; Tue, 12 Jan 2021 10:09:38 +0000 (UTC) Received: from [10.36.115.140] (ovpn-115-140.ams2.redhat.com [10.36.115.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB9B56A8FD; Tue, 12 Jan 2021 10:09:35 +0000 (UTC) Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform To: Anshuman Khandual , Oscar Salvador References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> <20210111134303.GA3031@linux> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <556a8a62-7bb2-d16b-67ea-57c87c1a6aa7@redhat.com> Date: Tue, 12 Jan 2021 11:09:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_050943_243014_532D1984 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-s390@vger.kernel.org, Vasily Gorbik , catalin.marinas@arm.com, hca@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12.01.21 04:51, Anshuman Khandual wrote: > > > On 1/11/21 7:13 PM, Oscar Salvador wrote: >> On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote: >>> AFAIKs, all memhp_get_pluggable_range() users pass "1". >>> >>> What about the "add_pages()-only" path? >> >> I guess you refer to memremap_pages(), right? > > Right, via pagemap_range(). > >> If so, moving the added memhp_range_allowed() check above the if-else might do >> the trick >> > We had that code in the earlier version. But dropped it, as we did > not want to add any new checks in the generic code. Can add it back > if that is preferred. I remember discussing replacing the check in __add_pages() instead. But I don't really care where the check ends up being. As discussed, at some point, we should provide versions of add_pages() and arch_add_pages() that don't immediately end in arch-code. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel