Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jingcheng Ji (纪京城)" <ot_jingcheng.ji@mediatek.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"Jarried Lin (林裕哲)" <Jarried.Lin@mediatek.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Vince-WL Liu (劉文龍)" <Vince-WL.Liu@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Justin Yeh (葉英茂)" <Justin.Yeh@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH] spi: spi-mtk-nor: Get clocks from devicetree in bulk
Date: Thu, 3 Sep 2026 06:13:02 +0000	[thread overview]
Message-ID: <556d2a683646776d9ef08f790aa118454739d994.camel@mediatek.com> (raw)
In-Reply-To: <b03aa685-3632-4a8e-a292-4d0897ba2c3e@sirena.org.uk>

On Mon, 2026-08-31 at 18:48 +0100, Mark Brown wrote:
> On Fri, Aug 21, 2026 at 05:00:22PM +0800, Jingcheng Ji wrote:
> > The driver currently gets a fixed set of clock inputs by name. This
> > ties
> > the driver to the clock names used by existing devicetrees and
> > silently
> > ignores any additional clocks declared by a future platform.
> 
> This doesn't apply against current code, please check and resend.

Dear Mark:
	Thanks for pointing this out. You are right: v1 was based on
an outdated snapshot and does not apply cleanly because current
spi/for-next already contains the err_disable_clk cleanup path added by
the IRQ error handling changes.

The fixed per-name clock lookups are still present in current spi/for-
next.I have rebased the patch onto the current tree, reused the
existing cleanup path, and verified v2 with checkpatch, git apply, git
am --3way, and an ARM64 object build.

I will send v2 shortly.

Best Regards,
Jingcheng Ji.



  reply	other threads:[~2026-09-03  6:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  9:00 [PATCH] spi: spi-mtk-nor: Get clocks from devicetree in bulk Jingcheng Ji
2026-08-31 17:48 ` Mark Brown
2026-09-03  6:13   ` Jingcheng Ji (纪京城) [this message]
2026-09-03  7:56 ` [PATCH v2] " Jingcheng Ji
2026-09-03  8:07 ` Jingcheng Ji
2026-09-03  8:09 ` Jingcheng Ji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556d2a683646776d9ef08f790aa118454739d994.camel@mediatek.com \
    --to=ot_jingcheng.ji@mediatek.com \
    --cc=Jarried.Lin@mediatek.com \
    --cc=Justin.Yeh@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Vince-WL.Liu@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox