linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kever.yang@rock-chips.com (Kever Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: rockchip: ensure CPU to enter WIF state
Date: Fri, 05 Jun 2015 14:32:27 +0800	[thread overview]
Message-ID: <5571427B.1040406@rock-chips.com> (raw)
In-Reply-To: <1433479677-18086-3-git-send-email-wxt@rock-chips.com>

Hi Caesar,

Subject typo WIF/WFI.

On 06/05/2015 12:47 PM, Caesar Wang wrote:
> In idle mode, core1/2/3 of Cortex-A17 should be either power off or in
> WFI/WFE state.
> we can delay 1ms to ensure the CPU enter WFI state.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
>   arch/arm/mach-rockchip/platsmp.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
> index 1230d3d..978c357 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -316,6 +316,9 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus)
>   #ifdef CONFIG_HOTPLUG_CPU
>   static int rockchip_cpu_kill(unsigned int cpu)
>   {
> +	/* ensure CPU can enter the WFI/WFE state */
> +	mdelay(1);
> +
Does it matter if core is not in WFI state when we want to power down it?

Thanks,
- Kever
>   	pmu_set_power_domain(0 + cpu, false);
>   	return 1;
>   }

  reply	other threads:[~2015-06-05  6:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  4:47 [PATCH 0/3] ARM: rockchip: fix the SMP Caesar Wang
2015-06-05  4:47 ` [PATCH 1/3] ARM: rockchip: fix the CPU soft reset Caesar Wang
2015-06-05  8:45   ` Heiko Stübner
2015-06-05  9:00     ` Caesar Wang
2015-06-05  9:46       ` Heiko Stübner
2015-06-05  4:47 ` [PATCH 2/3] ARM: rockchip: ensure CPU to enter WIF state Caesar Wang
2015-06-05  6:32   ` Kever Yang [this message]
2015-06-05  6:58     ` Caesar Wang
2015-06-05  4:47 ` [PATCH 3/3] ARM: rockchip: fix the SMP code style Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5571427B.1040406@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).