From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3
Date: Tue, 09 Jun 2015 08:50:38 +0900 [thread overview]
Message-ID: <55762A4E.5090208@samsung.com> (raw)
In-Reply-To: <1433696621-4763-1-git-send-email-linux.amoon@gmail.com>
On 08.06.2015 02:03, Anand Moon wrote:
> Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable
> sound on Odroid-XU3 board.
>
> Below is the output of boot log.
> [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43
> [ 6.025506] random: nonblocking pool is initialized
> [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok
> [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466)
> [ 6.123650] ALSA device list:
> [ 6.135203] #0: Odroid-XU3
Answering the question "why" and "what is device" would be sufficient.
You answered the first question ("enable sound") so you can just add
second part - using the max98090 audio codec.
This whole dmesg does not bring any benefits here, especially the
irrelevant items (like random or RTC). Could you trim the commit message?
Beside of that it looks fine however you marked this as "v2":
1. I cannot find v1 on Google. The title was the same?
2. Where is changelog?
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-06-08 23:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 17:03 [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 Anand Moon
2015-06-07 17:03 ` [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM " Anand Moon
2015-06-08 15:11 ` Lukasz Majewski
2015-06-08 23:56 ` Krzysztof Kozlowski
2015-06-09 3:08 ` Anand Moon
2015-09-02 14:12 ` Krzysztof Kozlowski
2015-09-02 15:40 ` Anand Moon
2015-06-08 15:10 ` [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 " Lukasz Majewski
2015-06-08 23:50 ` Krzysztof Kozlowski [this message]
2015-06-09 2:39 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55762A4E.5090208@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).