From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] [media] c8sectpfe: fix namespace on memcpy/memset
Date: Sat, 03 Oct 2015 00:27:34 +0200 [thread overview]
Message-ID: <5577273.mIdflaHak0@wuerfel> (raw)
In-Reply-To: <5347f97c651906887446a8811946e54b5a972fe4.1443737683.git.mchehab@osg.samsung.com>
On Thursday 01 October 2015 19:17:28 Mauro Carvalho Chehab wrote:
> @@ -1084,10 +1084,10 @@ static void load_dmem_segment(struct c8sectpfei *fei, Elf32_Phdr *phdr,
> seg_num, phdr->p_paddr, phdr->p_filesz,
> dst, phdr->p_memsz);
>
> - memcpy((void __iomem *)dst, (void *)fw->data + phdr->p_offset,
> + memcpy((void __force *)dst, (void *)fw->data + phdr->p_offset,
> phdr->p_filesz);
>
> - memset((void __iomem *)dst + phdr->p_filesz, 0,
> + memset((void __force *)dst + phdr->p_filesz, 0,
> phdr->p_memsz - phdr->p_filesz);
> }
>
Same here: this should really use memcpy_toio() for the first one, though it
seems we don't have a corresponding memset_io().
Arnd
prev parent reply other threads:[~2015-10-02 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1443737682.git.mchehab@osg.samsung.com>
2015-10-01 22:17 ` [PATCH 5/7] [media] mipi-csis: make sparse happy Mauro Carvalho Chehab
2015-10-02 22:25 ` Arnd Bergmann
2015-10-05 10:24 ` Sylwester Nawrocki
2015-10-05 11:07 ` Arnd Bergmann
2015-10-05 12:23 ` Sylwester Nawrocki
2015-10-01 22:17 ` [PATCH 6/7] [media] c8sectpfe: fix namespace on memcpy/memset Mauro Carvalho Chehab
2015-10-02 22:27 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5577273.mIdflaHak0@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).