From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] stm: add configfs dependency
Date: Sat, 17 Oct 2015 00:35:19 +0200 [thread overview]
Message-ID: <5578991.YxAbTTycJA@wuerfel> (raw)
There are three new stm modules, all of which use configfs for configuration.
If configfs is not part of the kernel, or is a loadable module while
the stm driver is builtin, we get a link error like:
drivers/built-in.o: In function `stp_policy_node_drop':
drivers/hwtracing/stm/policy.c:232: undefined reference to `config_item_put'
drivers/built-in.o: In function `stp_policies_make':
drivers/hwtracing/stm/policy.c:352: undefined reference to `config_group_init_type_name'
drivers/built-in.o: In function `stp_policy_node_make':
drivers/hwtracing/stm/policy.c:215: undefined reference to `config_group_init_type_name'
This adds explicit Kconfig dependencies to ensure configfs is present.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
The patches are currently in Greg's char-misc tree, we should have
this one in the same branch.
diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 5a59a28cc3da..6df294fff1eb 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -1,5 +1,6 @@
config STM
tristate "System Trace Module devices"
+ depends on CONFIGFS_FS
help
A System Trace Module (STM) is a device exporting data in System
Trace Protocol (STP) format as defined by MIPI STP standards.
@@ -9,6 +10,7 @@ config STM
config STM_DUMMY
tristate "Dummy STM driver"
+ depends on CONFIGFS_FS
help
This is a simple dummy device that pretends to be an stm device
and discards your data. Use for stm class testing.
@@ -17,6 +19,7 @@ config STM_DUMMY
config STM_SOURCE_CONSOLE
tristate "Kernel console over STM devices"
+ depends on CONFIGFS_FS
help
This is a kernel space trace source that sends kernel log
messages to trace hosts over STM devices.
next reply other threads:[~2015-10-16 22:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 22:35 Arnd Bergmann [this message]
2015-10-17 6:24 ` [PATCH] stm: add configfs dependency Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578991.YxAbTTycJA@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox