linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode
Date: Fri, 12 Jun 2015 11:25:17 +0200	[thread overview]
Message-ID: <557AA57D.1010104@xilinx.com> (raw)
In-Reply-To: <1434092004-21385-1-git-send-email-achandran@mvista.com>

On 06/12/2015 08:53 AM, Arun Chandran wrote:
> earlyprintk messages are not appearing on the terminal
> emulator during a big endian kernel boot. In BE mode
> sending full words to UART will result in unprintable
> characters as they are byte swapped versions of printable
> ones. So send only bytes.
> 
> Signed-off-by: Arun Chandran <achandran@mvista.com>
> ---
> ---
> Changes since v1:
> 	removed the byte swapping logic. Just send characters instead.
> ---
>  arch/arm/include/debug/zynq.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
> index bd13ded..de86b92 100644
> --- a/arch/arm/include/debug/zynq.S
> +++ b/arch/arm/include/debug/zynq.S
> @@ -38,7 +38,7 @@
>  		.endm
>  
>  		.macro	senduart,rd,rx
> -		str	\rd, [\rx, #UART_FIFO_OFFSET]	@ TXDATA
> +		strb	\rd, [\rx, #UART_FIFO_OFFSET]	@ TXDATA
>  		.endm
>  
>  		.macro	waituart,rd,rx
> 

ok - this works too.

Tested-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

      reply	other threads:[~2015-06-12  9:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 14:13 [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode Arun Chandran
2015-06-11 18:13 ` Michal Simek
2015-06-12  6:58   ` Arun Chandran
2015-06-12  6:53 ` [PATCH v2] " Arun Chandran
2015-06-12  9:25   ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557AA57D.1010104@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).