From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0229AC54E41 for ; Wed, 28 Feb 2024 09:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qu5MyEoZFjJH+GgJfoDx1bKEMOu9ZjaLN6gFt7P5+hs=; b=B37mWIC7Wd7tu1 AtSQKbhOOoLuIhQN5rV+3+sNduUth52tq59Zd3Fy8HG8o+5Xj2uv2VtwMfci1oMUPfOLNvPvOr7/R 2J6WKr2R9hEkEB8FpLvu+eYjhl4kwMOmoCBxceygXSEmajLoThFlFGdZxJTKZ7MBvoh3Tij5BKKgY c+j9Inw4zMvGP1hF0H6dGd/cXXCBLarp23FZiR39XdZCTdI9fr/GvmvvlJOst89saH7oCKv2WD+fv 2RIuCfAVonSwlO2gSWrVJ9CO67KC1kDYgIPvKYXavJ2ZEv8aKtrmNeZ4APONK04BRvD+UkB38+Ha8 ijfo+MCTt0TBaaQjwBJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfGOP-00000008iBq-1ssM; Wed, 28 Feb 2024 09:38:25 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfGOM-00000008iAg-0CPv for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 09:38:24 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-412b3f88132so3090015e9.0 for ; Wed, 28 Feb 2024 01:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709113100; x=1709717900; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=n4+AKRmkmBFEoLIViqECwVqYHAu9t9L66Ay6/6CX5qk=; b=Jpwo7dA74Fhn6uV8CIx4N02lIxg9NjNRlVvJ3O6ruSfGHYtG0P8RUMo7fIs/v/mMtZ 0lcC/g8if2jzt7Gz/Spvi6tvhJJiwYIyoS08iD1GY9L26iawIxjX6hedlLRDpv9vG1oz 03z1/5qelrQwCfhfAPylqXK43cSPK2fedKBMII4sSCTExpgwSWNSmEAAQmyxYt/QZ8Mc hvn/qn7MG8Sj1I4SFSAiBoPNRmXFcVghSmV3EFWPEjhvjWNu+Ju0JnPaDgYJNiyN4/vG Uj47beQIGS9qj6lidS4pe9s4KDi3HO85cv4gTXpxguCXlhqcy8qEHzZyknD1kW0X+Ey2 TsbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709113100; x=1709717900; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n4+AKRmkmBFEoLIViqECwVqYHAu9t9L66Ay6/6CX5qk=; b=SsWwjn9cZ1BHP+ghzEcFrg8ecTpOrWDkqskzlu9snR4tCRKFtZw8jVDv2avpIQR720 3Yuq/NV1k8OjovKiPZFngKYoUv0M7PcNmfywGb+uxxDv64lokUdL4nb/xwNjULgAi1BN FAf4UM/OwUdeyGTaUvP4HM+4ErBaUDWL8S44N/fEuvX2zGbdLTBTxABwElyvcBjgD71L nvjsB/4ahTLkRapEoKkAQQx+AR+5yJH4Jg2oO2voxVZTD0s44CwukP9T4Msof7kxnuJZ HOLrgGTCwOQOlr+7cIwj1EQNF7teCinCBqrSWR+rOUGiVvEojyVzz5k0IMC3ELKSOv/L 7CwA== X-Forwarded-Encrypted: i=1; AJvYcCX8pPtbdZNqmW26ar6TMog+ywcfd4GsPHypSc/Dk4BmGFsj9czlT9bIxT+4buN5nDT7Dtdpu5x9xZ9VEdZlbQm4SMPtBe1JXT9cd4l0cNk/F0Lr69c= X-Gm-Message-State: AOJu0Yw69W22EQ5RcWQrHkw0H7URE7L4WFWw2oEKZOy7mVtS2RHHISe8 9eObrqaS/t1LKgHPTtZEO4flzjj3sbxf4PRGeOAC3TBtKMNbYoouq9W1EJ18SZg= X-Google-Smtp-Source: AGHT+IHOp1pxzWYsSZdgMk9fzN4/wRCtOOeXX9R3/XcarEOcYQuEj1WE1Pi4WYyJuSqwQHpUbVzypA== X-Received: by 2002:a05:600c:a4c:b0:412:77cb:ae28 with SMTP id c12-20020a05600c0a4c00b0041277cbae28mr10799118wmq.11.1709113100097; Wed, 28 Feb 2024 01:38:20 -0800 (PST) Received: from [172.20.10.10] ([213.233.108.239]) by smtp.gmail.com with ESMTPSA id o8-20020a056000010800b0033d202abf01sm13843461wrx.28.2024.02.28.01.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 01:38:19 -0800 (PST) Message-ID: <557f369c-e6f9-4794-8d80-bda5c149db5e@linaro.org> Date: Wed, 28 Feb 2024 09:38:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list To: Varshini.Rajendran@microchip.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172638.672366-1-varshini.rajendran@microchip.com> <19da0e57-379b-4db3-ba8e-db7efe336e15@linaro.org> <98fedd3f-b55d-4ad1-b2ca-1efef0a19505@microchip.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <98fedd3f-b55d-4ad1-b2ca-1efef0a19505@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_013822_250320_B0042D3F X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/28/24 09:28, Varshini.Rajendran@microchip.com wrote: > Hi Tudor, > > On 26/02/24 2:39 pm, Tudor Ambarus wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 23.02.2024 19:26, Varshini Rajendran wrote: >>> Remove microchip,sam9x60-spi compatible from the list as the driver used >>> has the compatible atmel,at91rm9200-spi and sam9x60 devices also use the >>> same compatible as fallback. So removing the microchip,sam9x60-spi >>> compatible from the list since it is not needed. >>> >> >> I find this wrong. I though we shall add compatibles for each SoC. Are >> the registers and fields the same for the SPI IPs in these 2 SoCs? Even >> if they are the same, are you sure the IPs are integrated in the same way? > > Which two SoCs are you referring to ? > I am not removing the device specific compatible. I am only removing the > additional fallback compatible. > ah, I read it wrong, sorry > As in, > > compatible = "microchip,sam9x7-spi", "atmel,at91rm9200-spi"; > > instead of, > > compatible = "microchip,sam9x7-spi", "microchip,sam9x60-spi", > "atmel,at91rm9200-spi"; > > for the sam9x7 devices. > > Hope this is clear. If I have it wrong please let me know. it's clear now, thanks. I see in the driver that microchip,sam9x60-spi compatible is not yet used, thus removing the fallback to "microchip,sam9x60-spi" brings no functional change. Would have made a difference if sam9x60-spi implemented additional support that sam9x7-spi could have used as a fallback. If you think that sam9x7-spi will not fallback to sam9x60-spi in the future then: Reviewed-by: Tudor Ambarus > >> >>> Signed-off-by: Varshini Rajendran >>> --- >>> Changes in v4: >>> - Elaborated the explanation in the commit message to justify the patch >>> --- >>> Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >>> index 58367587bfbc..32e7c14033c2 100644 >>> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >>> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >>> @@ -22,7 +22,6 @@ properties: >>> - const: atmel,at91rm9200-spi >>> - items: >>> - const: microchip,sam9x7-spi >>> - - const: microchip,sam9x60-spi >>> - const: atmel,at91rm9200-spi >>> >>> reg: > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel