From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AC6C04AA7 for ; Mon, 13 May 2019 14:51:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 774842084A for ; Mon, 13 May 2019 14:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ifZiluKE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 774842084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xqho3fkEgq0xhFYUW+Dyopg8rjTw0Hoql86nA/XYO+s=; b=ifZiluKEDydkuG Gy6QVc2a+1rlgzHhA79RXp57Jx1IujKd7E5WUNav9st6nNLmaB5F+vFdfODT8cWYpt+ZETtbqI7fZ VMUOdTOjYEOMW5bX/af7ZNBAYg4vfB5YX4cnZXmzeVbf7NkkKakqjU6pYXESKYYtEn90F0Tz2BTwk kBuOEhKiRMcwxMJsksSUpFOpbs88A107dx52NvGI0M3oYQCMXxxRAfgdVOx9lR4M++IB86fbr8D89 NVBwBCEhiu1+Rddu3YZ4e8ZSpWk0eAegcZzH43dQgDRJmJjFQo2pnlPMf4Xzf4UudGPfYW/1NfBzp 1/YYscXWjgF3xl9RR0qQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQCIM-00030a-6a; Mon, 13 May 2019 14:51:14 +0000 Received: from ns.iliad.fr ([212.27.33.1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQCIJ-0002zg-13; Mon, 13 May 2019 14:51:12 +0000 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 3F90D1FF44; Mon, 13 May 2019 16:51:05 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 0834A1FF2B; Mon, 13 May 2019 16:51:05 +0200 (CEST) Subject: Re: [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8 To: Stanley Chu , linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, pedrom.sousa@synopsys.com References: <1557758186-18706-1-git-send-email-stanley.chu@mediatek.com> From: Marc Gonzalez Message-ID: <55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr> Date: Mon, 13 May 2019 16:51:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1557758186-18706-1-git-send-email-stanley.chu@mediatek.com> Content-Language: en-US X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Mon May 13 16:51:05 2019 +0200 (CEST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_075111_219041_87648832 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andy.teng@mediatek.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, evgreen@chromium.org, subhashj@codeaurora.org, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, vivek.gautam@codeaurora.org, matthias.bgg@gmail.com, sayalil@codeaurora.org, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/05/2019 16:36, Stanley Chu wrote: > Currently auto-hibern8 is activated if host supports > auto-hibern8 capability. However no error handlings are existed thus > this feature is kind of risky. This last sentence is not very idiomatic. I would suggest: "However, error-handling is not implemented, which makes the feature somewhat risky." > If "Hibernate Enter" or "Hibernate Exit" fail happens I would suggest: If either "Hibernate Enter" or "Hibernate Exit" fail during ... > during auto-hibern8 flow, the corresponding interrupt > "UIC_HIBERNATE_ENTER" or "UIC_HIBERNATE_EXIT" shall be raised > according to UFS specification. > > This patch adds auto-hibern8 error handlings: error-handling > - Monitor "Hibernate Enter" and "Hibernate Exit" interrupts after > auto-hibern8 feature is activated. I just want to take this opportunity to ask a rhetorical question. Who in the Great Heavens thought it would be a good idea to call the feature "auto-hibern8" ? Was it really worth it to save 2 characters by writing "8" instead of "ate" ? This bugs me so much that I just might send a patch to fix it up. Regards. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel