From: inki.dae@samsung.com (Inki Dae)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj
Date: Fri, 19 Jun 2015 14:28:31 +0900 [thread overview]
Message-ID: <5583A87F.5090807@samsung.com> (raw)
In-Reply-To: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com>
On 2015? 06? 19? 14:23, Krzysztof Kozlowski wrote:
> The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in
> 2a3098ff6c21 ("drm/exynos: add userptr feature for g2d module") but is
> not referenced anywhere.
>
> One instance of 'exynos_drm_gem_obj' may be mapped to multiple
> user-space VMAs so 'vma' field does not look useful anyway.
Krzysztof,
The vma member would be removed by below patch,
http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html
Thanks,
Inki Dae
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h
> index 308173cb4f0a..6f42e2248288 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h
> @@ -61,7 +61,6 @@ struct exynos_drm_gem_buf {
> * or at framebuffer creation.
> * @size: size requested from user, in bytes and this size is aligned
> * in page unit.
> - * @vma: a pointer to vm_area.
> * @flags: indicate memory type to allocated buffer and cache attruibute.
> *
> * P.S. this object would be transferred to user as kms_bo.handle so
> @@ -71,7 +70,6 @@ struct exynos_drm_gem_obj {
> struct drm_gem_object base;
> struct exynos_drm_gem_buf *buffer;
> unsigned long size;
> - struct vm_area_struct *vma;
> unsigned int flags;
> };
>
>
next prev parent reply other threads:[~2015-06-19 5:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 5:23 [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj Krzysztof Kozlowski
2015-06-19 5:28 ` Inki Dae [this message]
2015-06-19 5:46 ` Krzysztof Kozlowski
2015-06-19 6:03 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583A87F.5090807@samsung.com \
--to=inki.dae@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).