linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ACPI / ARM64 : use the new BAD_MADT_GICC_ENTRY macro
Date: Fri, 19 Jun 2015 18:52:12 +0800	[thread overview]
Message-ID: <5583F45C.2070708@linaro.org> (raw)
In-Reply-To: <1434666968-1543-4-git-send-email-al.stone@linaro.org>

On 06/19/2015 06:36 AM, Al Stone wrote:
> For those parts of the arm64 ACPI code that need to check GICC subtables
> in the MADT, use the new BAD_MADT_GICC_ENTRY macro instead of the previous
> BAD_MADT_ENTRY.  The new macro takes into account differences in the size
> of the GICC subtable that the old macro did not; this caused failures even
> though the subtable entries are valid.
>
> Signed-off-by: Al Stone <al.stone@linaro.org>
> ---
>   arch/arm64/kernel/smp.c   | 2 +-
>   drivers/irqchip/irq-gic.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 4b2121b..80d5984 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -438,7 +438,7 @@ acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header,
>   	struct acpi_madt_generic_interrupt *processor;
>
>   	processor = (struct acpi_madt_generic_interrupt *)header;
> -	if (BAD_MADT_ENTRY(processor, end))
> +	if (BAD_MADT_GICC_ENTRY(processor, end))
>   		return -EINVAL;
>
>   	acpi_table_print_madt_entry(header);
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 8d7e1c8..4dd8826 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -1055,7 +1055,7 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header,
>
>   	processor = (struct acpi_madt_generic_interrupt *)header;
>
> -	if (BAD_MADT_ENTRY(processor, end))
> +	if (BAD_MADT_GICC_ENTRY(processor, end))
>   		return -EINVAL;

Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>

Thanks
Hanjun

  parent reply	other threads:[~2015-06-19 10:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 22:36 [PATCH v2 0/3] Correct for ACPI 5.1->6.0 spec changes in MADT GICC entries Al Stone
2015-06-18 22:36 ` [PATCH v2 1/3] ACPI : introduce macros for using the ACPI specification version Al Stone
2015-06-19 10:49   ` Hanjun Guo
2015-06-19 20:01     ` Al Stone
2015-06-30 20:12   ` Rafael J. Wysocki
2015-06-30 21:15     ` Al Stone
2015-07-01  2:30       ` Hanjun Guo
2015-06-18 22:36 ` [PATCH v2 2/3] ACPI: add BAD_MADT_GICC_ENTRY() macro Al Stone
2015-06-19 10:49   ` Hanjun Guo
2015-06-19 20:02     ` Al Stone
2015-06-18 22:36 ` [PATCH v2 3/3] ACPI / ARM64 : use the new BAD_MADT_GICC_ENTRY macro Al Stone
2015-06-19  9:46   ` Will Deacon
2015-06-19 20:03     ` Al Stone
2015-06-19 10:52   ` Hanjun Guo [this message]
2015-06-19 10:54 ` [PATCH v2 0/3] Correct for ACPI 5.1->6.0 spec changes in MADT GICC entries Hanjun Guo
2015-06-19 20:05   ` Al Stone
2015-06-30 17:07 ` Sudeep Holla
2015-06-30 17:29   ` Al Stone
2015-06-30 18:25     ` Rafael J. Wysocki
2015-06-30 18:35       ` Rafael J. Wysocki
2015-07-01  2:06         ` Hanjun Guo
2015-07-02 18:25           ` Al Stone
2015-06-30 18:39       ` Al Stone
2015-06-30 19:05         ` Rafael J. Wysocki
2015-06-30 19:57           ` Al Stone
2015-06-30 19:45       ` Al Stone
2015-06-30 19:58         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5583F45C.2070708@linaro.org \
    --to=hanjun.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).