* [PATCH v2] ARM: socfpga: dts: Add adxl34x @ 2014-12-24 23:11 Walter Lozano 2015-01-02 5:11 ` Pavel Machek 2015-01-05 9:21 ` Steffen Trumtrar 0 siblings, 2 replies; 11+ messages in thread From: Walter Lozano @ 2014-12-24 23:11 UTC (permalink / raw) To: linux-arm-kernel This patch adds the DTS bindings for the adxl34x digital accelerometer. Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> --- arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts index 16ea6f5..d343e03 100644 --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts @@ -60,6 +60,22 @@ rxc-skew-ps = <2000>; }; +&gpio2 { + status = "okay"; +}; + +&i2c1 { + status = "okay"; + + accel1: accelerometer at 53 { + compatible = "adxl34x"; + reg = <0x53>; + + interrupt-parent = <&portc>; + interrupts = <3 2>; + }; +}; + &mmc0 { vmmc-supply = <®ulator_3_3v>; vqmmc-supply = <®ulator_3_3v>; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2014-12-24 23:11 [PATCH v2] ARM: socfpga: dts: Add adxl34x Walter Lozano @ 2015-01-02 5:11 ` Pavel Machek 2015-01-05 9:21 ` Steffen Trumtrar 1 sibling, 0 replies; 11+ messages in thread From: Pavel Machek @ 2015-01-02 5:11 UTC (permalink / raw) To: linux-arm-kernel On Wed 2014-12-24 20:11:52, Walter Lozano wrote: > This patch adds the DTS bindings for the adxl34x digital > accelerometer. > > Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> Acked-by: Pavel Machek <pavel@ucw.cz> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2014-12-24 23:11 [PATCH v2] ARM: socfpga: dts: Add adxl34x Walter Lozano 2015-01-02 5:11 ` Pavel Machek @ 2015-01-05 9:21 ` Steffen Trumtrar 2015-03-16 13:10 ` Walter Lozano 1 sibling, 1 reply; 11+ messages in thread From: Steffen Trumtrar @ 2015-01-05 9:21 UTC (permalink / raw) To: linux-arm-kernel Hi! On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: > This patch adds the DTS bindings for the adxl34x digital > accelerometer. > > Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> > --- > arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts > index 16ea6f5..d343e03 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts > @@ -60,6 +60,22 @@ > rxc-skew-ps = <2000>; > }; > > +&gpio2 { > + status = "okay"; > +}; > + > +&i2c1 { > + status = "okay"; > + > + accel1: accelerometer at 53 { > + compatible = "adxl34x"; > + reg = <0x53>; > + > + interrupt-parent = <&portc>; > + interrupts = <3 2>; > + }; > +}; > + > &mmc0 { > vmmc-supply = <®ulator_3_3v>; > vqmmc-supply = <®ulator_3_3v>; I just gave it a short spin. I get some interrupts and the position property changes, so it seems to work: Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-01-05 9:21 ` Steffen Trumtrar @ 2015-03-16 13:10 ` Walter Lozano 2015-03-19 21:27 ` Walter Lozano 0 siblings, 1 reply; 11+ messages in thread From: Walter Lozano @ 2015-03-16 13:10 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar <s.trumtrar@pengutronix.de> wrote: > Hi! > > On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >> This patch adds the DTS bindings for the adxl34x digital >> accelerometer. >> >> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >> --- >> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> index 16ea6f5..d343e03 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> @@ -60,6 +60,22 @@ >> rxc-skew-ps = <2000>; >> }; >> >> +&gpio2 { >> + status = "okay"; >> +}; >> + >> +&i2c1 { >> + status = "okay"; >> + >> + accel1: accelerometer at 53 { >> + compatible = "adxl34x"; >> + reg = <0x53>; >> + >> + interrupt-parent = <&portc>; >> + interrupts = <3 2>; >> + }; >> +}; >> + >> &mmc0 { >> vmmc-supply = <®ulator_3_3v>; >> vqmmc-supply = <®ulator_3_3v>; > > I just gave it a short spin. I get some interrupts and the position property > changes, so it seems to work: > > Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > Regards, > Steffen > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | Ping? How should this continue? Regards, Walter -- Walter Lozano, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-03-16 13:10 ` Walter Lozano @ 2015-03-19 21:27 ` Walter Lozano 2015-03-23 3:03 ` Dinh Nguyen 0 siblings, 1 reply; 11+ messages in thread From: Walter Lozano @ 2015-03-19 21:27 UTC (permalink / raw) To: linux-arm-kernel Hi Dinh, On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano <walter@vanguardiasur.com.ar> wrote: > On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar > <s.trumtrar@pengutronix.de> wrote: >> Hi! >> >> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>> This patch adds the DTS bindings for the adxl34x digital >>> accelerometer. >>> >>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>> --- >>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>> index 16ea6f5..d343e03 100644 >>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>> @@ -60,6 +60,22 @@ >>> rxc-skew-ps = <2000>; >>> }; >>> >>> +&gpio2 { >>> + status = "okay"; >>> +}; >>> + >>> +&i2c1 { >>> + status = "okay"; >>> + >>> + accel1: accelerometer at 53 { >>> + compatible = "adxl34x"; >>> + reg = <0x53>; >>> + >>> + interrupt-parent = <&portc>; >>> + interrupts = <3 2>; >>> + }; >>> +}; >>> + >>> &mmc0 { >>> vmmc-supply = <®ulator_3_3v>; >>> vqmmc-supply = <®ulator_3_3v>; >> >> I just gave it a short spin. I get some interrupts and the position property >> changes, so it seems to work: >> >> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> > > Ping? > How should this continue? Any news about this patch? It has been acked by Pavel Machek and Steffen Trumtrar a while ago. Regards, -- Walter Lozano, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-03-19 21:27 ` Walter Lozano @ 2015-03-23 3:03 ` Dinh Nguyen 2015-03-24 2:29 ` Walter Lozano 0 siblings, 1 reply; 11+ messages in thread From: Dinh Nguyen @ 2015-03-23 3:03 UTC (permalink / raw) To: linux-arm-kernel Hi Walter, On 3/19/15 4:27 PM, Walter Lozano wrote: > Hi Dinh, > > On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano > <walter@vanguardiasur.com.ar> wrote: >> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >> <s.trumtrar@pengutronix.de> wrote: >>> Hi! >>> >>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>> This patch adds the DTS bindings for the adxl34x digital >>>> accelerometer. >>>> >>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>>> --- >>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>> index 16ea6f5..d343e03 100644 >>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>> @@ -60,6 +60,22 @@ >>>> rxc-skew-ps = <2000>; >>>> }; >>>> >>>> +&gpio2 { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&i2c1 { >>>> + status = "okay"; >>>> + >>>> + accel1: accelerometer at 53 { >>>> + compatible = "adxl34x"; Shouldn't this be "adi,adxl34x"? At least that's what the documentation says. >>>> + reg = <0x53>; >>>> + >>>> + interrupt-parent = <&portc>; >>>> + interrupts = <3 2>; >>>> + }; >>>> +}; >>>> + >>>> &mmc0 { >>>> vmmc-supply = <®ulator_3_3v>; >>>> vqmmc-supply = <®ulator_3_3v>; >>> >>> I just gave it a short spin. I get some interrupts and the position property >>> changes, so it seems to work: >>> >>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>> >> >> Ping? >> How should this continue? > > Any news about this patch? It has been acked by Pavel Machek and > Steffen Trumtrar a while ago. > Sorry, since I wasn't CC on the original patch and somehow my filter didn't catch it, I didn't see this patch until now. Dinh ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-03-23 3:03 ` Dinh Nguyen @ 2015-03-24 2:29 ` Walter Lozano 2015-06-23 20:20 ` Walter Lozano 0 siblings, 1 reply; 11+ messages in thread From: Walter Lozano @ 2015-03-24 2:29 UTC (permalink / raw) To: linux-arm-kernel Hi Dinh On Mon, Mar 23, 2015 at 12:03 AM, Dinh Nguyen <dinguyen@opensource.altera.com> wrote: > Hi Walter, > > On 3/19/15 4:27 PM, Walter Lozano wrote: >> Hi Dinh, >> >> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano >> <walter@vanguardiasur.com.ar> wrote: >>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >>> <s.trumtrar@pengutronix.de> wrote: >>>> Hi! >>>> >>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>>> This patch adds the DTS bindings for the adxl34x digital >>>>> accelerometer. >>>>> >>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>>>> --- >>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>>> 1 file changed, 16 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>> index 16ea6f5..d343e03 100644 >>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>> @@ -60,6 +60,22 @@ >>>>> rxc-skew-ps = <2000>; >>>>> }; >>>>> >>>>> +&gpio2 { >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&i2c1 { >>>>> + status = "okay"; >>>>> + >>>>> + accel1: accelerometer at 53 { >>>>> + compatible = "adxl34x"; > > Shouldn't this be "adi,adxl34x"? At least that's what the documentation > says. > >>>>> + reg = <0x53>; >>>>> + >>>>> + interrupt-parent = <&portc>; >>>>> + interrupts = <3 2>; >>>>> + }; >>>>> +}; >>>>> + >>>>> &mmc0 { >>>>> vmmc-supply = <®ulator_3_3v>; >>>>> vqmmc-supply = <®ulator_3_3v>; >>>> >>>> I just gave it a short spin. I get some interrupts and the position property >>>> changes, so it seems to work: >>>> >>>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>>> >>> >>> Ping? >>> How should this continue? >> >> Any news about this patch? It has been acked by Pavel Machek and >> Steffen Trumtrar a while ago. >> > > Sorry, since I wasn't CC on the original patch and somehow my filter > didn't catch it, I didn't see this patch until now. No problem, I know it was my fault as I trust the output of get_maintainer.pl Regards, -- Walter Lozano, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-03-24 2:29 ` Walter Lozano @ 2015-06-23 20:20 ` Walter Lozano 2015-06-25 7:28 ` Geert Uytterhoeven 0 siblings, 1 reply; 11+ messages in thread From: Walter Lozano @ 2015-06-23 20:20 UTC (permalink / raw) To: linux-arm-kernel On Mon, Mar 23, 2015 at 11:29 PM, Walter Lozano <walter@vanguardiasur.com.ar> wrote: > Hi Dinh > > On Mon, Mar 23, 2015 at 12:03 AM, Dinh Nguyen > <dinguyen@opensource.altera.com> wrote: >> Hi Walter, >> >> On 3/19/15 4:27 PM, Walter Lozano wrote: >>> Hi Dinh, >>> >>> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano >>> <walter@vanguardiasur.com.ar> wrote: >>>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >>>> <s.trumtrar@pengutronix.de> wrote: >>>>> Hi! >>>>> >>>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>>>> This patch adds the DTS bindings for the adxl34x digital >>>>>> accelerometer. >>>>>> >>>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>>>>> --- >>>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>>>> 1 file changed, 16 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>> index 16ea6f5..d343e03 100644 >>>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>> @@ -60,6 +60,22 @@ >>>>>> rxc-skew-ps = <2000>; >>>>>> }; >>>>>> >>>>>> +&gpio2 { >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&i2c1 { >>>>>> + status = "okay"; >>>>>> + >>>>>> + accel1: accelerometer at 53 { >>>>>> + compatible = "adxl34x"; >> >> Shouldn't this be "adi,adxl34x"? At least that's what the documentation >> says. >> >>>>>> + reg = <0x53>; >>>>>> + >>>>>> + interrupt-parent = <&portc>; >>>>>> + interrupts = <3 2>; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>>> &mmc0 { >>>>>> vmmc-supply = <®ulator_3_3v>; >>>>>> vqmmc-supply = <®ulator_3_3v>; >>>>> >>>>> I just gave it a short spin. I get some interrupts and the position property >>>>> changes, so it seems to work: >>>>> >>>>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>>>> >>>> >>>> Ping? >>>> How should this continue? >>> >>> Any news about this patch? It has been acked by Pavel Machek and >>> Steffen Trumtrar a while ago. >>> >> >> Sorry, since I wasn't CC on the original patch and somehow my filter >> didn't catch it, I didn't see this patch until now. > > No problem, I know it was my fault as I trust the output of get_maintainer.pl > Ping? -- Walter Lozano, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-06-23 20:20 ` Walter Lozano @ 2015-06-25 7:28 ` Geert Uytterhoeven 2015-06-25 17:01 ` Walter Lozano 0 siblings, 1 reply; 11+ messages in thread From: Geert Uytterhoeven @ 2015-06-25 7:28 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jun 23, 2015 at 10:20 PM, Walter Lozano <walter@vanguardiasur.com.ar> wrote: > On Mon, Mar 23, 2015 at 11:29 PM, Walter Lozano > <walter@vanguardiasur.com.ar> wrote: >> On Mon, Mar 23, 2015 at 12:03 AM, Dinh Nguyen >> <dinguyen@opensource.altera.com> wrote: >>> On 3/19/15 4:27 PM, Walter Lozano wrote: >>>> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano >>>> <walter@vanguardiasur.com.ar> wrote: >>>>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >>>>> <s.trumtrar@pengutronix.de> wrote: >>>>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>>>>> This patch adds the DTS bindings for the adxl34x digital >>>>>>> accelerometer. >>>>>>> >>>>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>>>>>> --- >>>>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>>>>> 1 file changed, 16 insertions(+) >>>>>>> >>>>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>> index 16ea6f5..d343e03 100644 >>>>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>> @@ -60,6 +60,22 @@ >>>>>>> rxc-skew-ps = <2000>; >>>>>>> }; >>>>>>> >>>>>>> +&gpio2 { >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>>> + >>>>>>> +&i2c1 { >>>>>>> + status = "okay"; >>>>>>> + >>>>>>> + accel1: accelerometer at 53 { >>>>>>> + compatible = "adxl34x"; >>> >>> Shouldn't this be "adi,adxl34x"? At least that's what the documentation >>> says. >>> >>>>>>> + reg = <0x53>; >>>>>>> + >>>>>>> + interrupt-parent = <&portc>; >>>>>>> + interrupts = <3 2>; >>>>>>> + }; >>>>>>> +}; >>>>>>> + >>>>>>> &mmc0 { >>>>>>> vmmc-supply = <®ulator_3_3v>; >>>>>>> vqmmc-supply = <®ulator_3_3v>; >>>>>> >>>>>> I just gave it a short spin. I get some interrupts and the position property >>>>>> changes, so it seems to work: >>>>>> >>>>>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>>>>> >>>>> >>>>> Ping? >>>>> How should this continue? >>>> >>>> Any news about this patch? It has been acked by Pavel Machek and >>>> Steffen Trumtrar a while ago. >>>> >>> >>> Sorry, since I wasn't CC on the original patch and somehow my filter >>> didn't catch it, I didn't see this patch until now. >> >> No problem, I know it was my fault as I trust the output of get_maintainer.pl >> > > Ping? > > -- > Walter Lozano, VanguardiaSur > www.vanguardiasur.com.ar > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Now these commits are in: - 3a38958d2477b718 ("Input: adxl34x - add OF match support") [1] - e465bf6fc55d5ce2 ("DT: i2c: Deprecate adi,adxl34x compatible string") [2] you can use "adi,adxl345" (or "adi,adxl346", "adi,adxl345"). [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3a38958d2477b718d1011fb88c24c4f264ee9700 [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e465bf6fc55d5ce21fb45a75c3fa613505e6be20 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-06-25 7:28 ` Geert Uytterhoeven @ 2015-06-25 17:01 ` Walter Lozano 2015-06-25 17:05 ` Dinh Nguyen 0 siblings, 1 reply; 11+ messages in thread From: Walter Lozano @ 2015-06-25 17:01 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jun 25, 2015 at 4:28 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, Jun 23, 2015 at 10:20 PM, Walter Lozano > <walter@vanguardiasur.com.ar> wrote: >> On Mon, Mar 23, 2015 at 11:29 PM, Walter Lozano >> <walter@vanguardiasur.com.ar> wrote: >>> On Mon, Mar 23, 2015 at 12:03 AM, Dinh Nguyen >>> <dinguyen@opensource.altera.com> wrote: >>>> On 3/19/15 4:27 PM, Walter Lozano wrote: >>>>> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano >>>>> <walter@vanguardiasur.com.ar> wrote: >>>>>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >>>>>> <s.trumtrar@pengutronix.de> wrote: >>>>>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>>>>>> This patch adds the DTS bindings for the adxl34x digital >>>>>>>> accelerometer. >>>>>>>> >>>>>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>>>>>>> --- >>>>>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>>>>>> 1 file changed, 16 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>> index 16ea6f5..d343e03 100644 >>>>>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>> @@ -60,6 +60,22 @@ >>>>>>>> rxc-skew-ps = <2000>; >>>>>>>> }; >>>>>>>> >>>>>>>> +&gpio2 { >>>>>>>> + status = "okay"; >>>>>>>> +}; >>>>>>>> + >>>>>>>> +&i2c1 { >>>>>>>> + status = "okay"; >>>>>>>> + >>>>>>>> + accel1: accelerometer at 53 { >>>>>>>> + compatible = "adxl34x"; >>>> >>>> Shouldn't this be "adi,adxl34x"? At least that's what the documentation >>>> says. >>>> >>>>>>>> + reg = <0x53>; >>>>>>>> + >>>>>>>> + interrupt-parent = <&portc>; >>>>>>>> + interrupts = <3 2>; >>>>>>>> + }; >>>>>>>> +}; >>>>>>>> + >>>>>>>> &mmc0 { >>>>>>>> vmmc-supply = <®ulator_3_3v>; >>>>>>>> vqmmc-supply = <®ulator_3_3v>; >>>>>>> >>>>>>> I just gave it a short spin. I get some interrupts and the position property >>>>>>> changes, so it seems to work: >>>>>>> >>>>>>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>>>>>> >>>>>> >>>>>> Ping? >>>>>> How should this continue? >>>>> >>>>> Any news about this patch? It has been acked by Pavel Machek and >>>>> Steffen Trumtrar a while ago. >>>>> >>>> >>>> Sorry, since I wasn't CC on the original patch and somehow my filter >>>> didn't catch it, I didn't see this patch until now. >>> >>> No problem, I know it was my fault as I trust the output of get_maintainer.pl >>> >> >> Ping? >> >> -- >> Walter Lozano, VanguardiaSur >> www.vanguardiasur.com.ar >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Now these commits are in: > - 3a38958d2477b718 ("Input: adxl34x - add OF match support") [1] > - e465bf6fc55d5ce2 ("DT: i2c: Deprecate adi,adxl34x compatible string") [2] > > you can use "adi,adxl345" (or "adi,adxl346", "adi,adxl345"). > > [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3a38958d2477b718d1011fb88c24c4f264ee9700 > [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e465bf6fc55d5ce21fb45a75c3fa613505e6be20 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Thanks for the information Geert. Dihn, as I can see you have apply an old version of the this patch (V1), instead of V2 which has some format corrections suggested by Steffen Trumtrar. I addition, as Geert points, the compatibility string should now be updated. How would you like to proceed? Regards -- Walter Lozano, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ARM: socfpga: dts: Add adxl34x 2015-06-25 17:01 ` Walter Lozano @ 2015-06-25 17:05 ` Dinh Nguyen 0 siblings, 0 replies; 11+ messages in thread From: Dinh Nguyen @ 2015-06-25 17:05 UTC (permalink / raw) To: linux-arm-kernel On 6/25/15 12:01 PM, Walter Lozano wrote: > On Thu, Jun 25, 2015 at 4:28 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> On Tue, Jun 23, 2015 at 10:20 PM, Walter Lozano >> <walter@vanguardiasur.com.ar> wrote: >>> On Mon, Mar 23, 2015 at 11:29 PM, Walter Lozano >>> <walter@vanguardiasur.com.ar> wrote: >>>> On Mon, Mar 23, 2015 at 12:03 AM, Dinh Nguyen >>>> <dinguyen@opensource.altera.com> wrote: >>>>> On 3/19/15 4:27 PM, Walter Lozano wrote: >>>>>> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano >>>>>> <walter@vanguardiasur.com.ar> wrote: >>>>>>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >>>>>>> <s.trumtrar@pengutronix.de> wrote: >>>>>>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>>>>>>> This patch adds the DTS bindings for the adxl34x digital >>>>>>>>> accelerometer. >>>>>>>>> >>>>>>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar> >>>>>>>>> --- >>>>>>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>>>>>>> 1 file changed, 16 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>>> index 16ea6f5..d343e03 100644 >>>>>>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>>> @@ -60,6 +60,22 @@ >>>>>>>>> rxc-skew-ps = <2000>; >>>>>>>>> }; >>>>>>>>> >>>>>>>>> +&gpio2 { >>>>>>>>> + status = "okay"; >>>>>>>>> +}; >>>>>>>>> + >>>>>>>>> +&i2c1 { >>>>>>>>> + status = "okay"; >>>>>>>>> + >>>>>>>>> + accel1: accelerometer at 53 { >>>>>>>>> + compatible = "adxl34x"; >>>>> >>>>> Shouldn't this be "adi,adxl34x"? At least that's what the documentation >>>>> says. >>>>> >>>>>>>>> + reg = <0x53>; >>>>>>>>> + >>>>>>>>> + interrupt-parent = <&portc>; >>>>>>>>> + interrupts = <3 2>; >>>>>>>>> + }; >>>>>>>>> +}; >>>>>>>>> + >>>>>>>>> &mmc0 { >>>>>>>>> vmmc-supply = <®ulator_3_3v>; >>>>>>>>> vqmmc-supply = <®ulator_3_3v>; >>>>>>>> >>>>>>>> I just gave it a short spin. I get some interrupts and the position property >>>>>>>> changes, so it seems to work: >>>>>>>> >>>>>>>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>>>>>>> >>>>>>> >>>>>>> Ping? >>>>>>> How should this continue? >>>>>> >>>>>> Any news about this patch? It has been acked by Pavel Machek and >>>>>> Steffen Trumtrar a while ago. >>>>>> >>>>> >>>>> Sorry, since I wasn't CC on the original patch and somehow my filter >>>>> didn't catch it, I didn't see this patch until now. >>>> >>>> No problem, I know it was my fault as I trust the output of get_maintainer.pl >>>> >>> >>> Ping? >>> >>> -- >>> Walter Lozano, VanguardiaSur >>> www.vanguardiasur.com.ar >>> -- >>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>> the body of a message to majordomo at vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> Now these commits are in: >> - 3a38958d2477b718 ("Input: adxl34x - add OF match support") [1] >> - e465bf6fc55d5ce2 ("DT: i2c: Deprecate adi,adxl34x compatible string") [2] >> >> you can use "adi,adxl345" (or "adi,adxl346", "adi,adxl345"). >> >> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3a38958d2477b718d1011fb88c24c4f264ee9700 >> [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e465bf6fc55d5ce21fb45a75c3fa613505e6be20 >> >> Gr{oetje,eeting}s, >> >> Geert >> >> -- >> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org >> >> In personal conversations with technical people, I call myself a hacker. But >> when I'm talking to journalists I just say "programmer" or something like that. >> -- Linus Torvalds > > > Thanks for the information Geert. > > Dihn, as I can see you have apply an old version of the this patch > (V1), instead of V2 which has some format corrections suggested by > Steffen Trumtrar. I addition, as Geert points, the compatibility > string should now be updated. > > How would you like to proceed? > Your commit is staged for v4.2 in the arm-soc tree[1]. Please submit a patch to correct it for an -rc. [1] https://git.kernel.org/cgit/linux/kernel/git/arm/arm-soc.git/commit/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts?h=for-next&id=bf513bf04660321eb6181082def79ee1fd93b48f Dinh ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-06-25 17:05 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-24 23:11 [PATCH v2] ARM: socfpga: dts: Add adxl34x Walter Lozano 2015-01-02 5:11 ` Pavel Machek 2015-01-05 9:21 ` Steffen Trumtrar 2015-03-16 13:10 ` Walter Lozano 2015-03-19 21:27 ` Walter Lozano 2015-03-23 3:03 ` Dinh Nguyen 2015-03-24 2:29 ` Walter Lozano 2015-06-23 20:20 ` Walter Lozano 2015-06-25 7:28 ` Geert Uytterhoeven 2015-06-25 17:01 ` Walter Lozano 2015-06-25 17:05 ` Dinh Nguyen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).