From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: kernel: psci: use restart_handlers instead of arm_pm_restart
Date: Fri, 26 Jun 2015 10:08:47 +0100 [thread overview]
Message-ID: <558D169F.7000804@arm.com> (raw)
In-Reply-To: <1622532.VhvqsHJ0rH@diego>
+Mark, Lorenzo
On 26/06/15 00:33, Heiko St?bner wrote:
> Instead of hogging the arm_pm_restart callback, register a restart_handler
> to make it possible for machines to register more board-specific
> restart functionality.
>
Just curious to know why do you need board specific restart handlers in
Linux. The firmware implementing PSCI is board specific and can deal
with all board specific handling in the firmware.
> The priority is set to 127, 1 below the "default" to facilitate for
> example the use of regular per-soc restart handlers at their default
> priority 128 and others like the gpio-restart at priority 129 or above.
>
> Non-psci restarts can be necessary when either the psci implementation
> is faulty and does not implement the restart callback or devices need
Interesting, SYSTEM_RESET is mandatory from PSCIv0.2 and why only
exception for faulty PSCI system reset while it's assumed all other
features are never faulty. IMO it needs to be fixed in the firmware.
> even more custom restart operations, like recent rk3288-chromebooks.
> While the soc-level restart could restart those, an external component
> needed to be also reset (via gpio-restart) to allow the device to even
> boot again.
>
Again firmware implementing PSCI is platform specific and can deal any
such customization required.
By the way, I am not arguing against usage of register_restart_handler
over arm_pm_restart, but the reasoning given here.
Regards,
Sudeep
next prev parent reply other threads:[~2015-06-26 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 23:33 [PATCH] ARM64: kernel: psci: use restart_handlers instead of arm_pm_restart Heiko Stübner
2015-06-26 9:08 ` Sudeep Holla [this message]
2015-06-26 13:17 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D169F.7000804@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).