From: santosh.shilimkar@oracle.com (santosh shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap
Date: Tue, 30 Jun 2015 07:50:45 -0700 [thread overview]
Message-ID: <5592ACC5.4010500@oracle.com> (raw)
In-Reply-To: <1435661062-4127-1-git-send-email-grygorii.strashko@ti.com>
On 6/30/2015 3:44 AM, Grygorii Strashko wrote:
> On some PAE systems (e.g. TI Keystone), memory is above the 32-bit
> addressable limit, and the interconnect provides an aliased view of
> parts of physical memory in the 32-bit addressable space. This alias
> is strictly for boot time usage, and is not otherwise usable because
> of coherency limitations.
>
> On such systems, the idmap mechanism has to be used to pass correct
> boot address of secondary CPU to FW.
> virt_to_idmap() will fall-back to existing virt_to_phys() macro if
> such conversation is not required.
>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Nicolas Pitre <nico@linaro.org>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: Vitaly Andrianov <vitalya@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
> arch/arm/kernel/psci_smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c
> index 28a1db4..244aadd 100644
> --- a/arch/arm/kernel/psci_smp.c
> +++ b/arch/arm/kernel/psci_smp.c
> @@ -51,7 +51,7 @@ static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle)
> {
> if (psci_ops.cpu_on)
> return psci_ops.cpu_on(cpu_logical_map(cpu),
> - __pa(secondary_startup));
> + virt_to_idmap(&secondary_startup));
> return -ENODEV;
> }
>
>
next prev parent reply other threads:[~2015-06-30 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 10:44 [PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap Grygorii Strashko
2015-06-30 14:50 ` santosh shilimkar [this message]
2015-06-30 15:05 ` Russell King - ARM Linux
2015-06-30 15:59 ` Nicolas Pitre
2015-06-30 16:28 ` Vitaly Andrianov
2015-06-30 16:18 ` Mark Rutland
2015-06-30 20:25 ` Russell King - ARM Linux
2015-07-02 10:07 ` Grygorii Strashko
2015-07-02 10:29 ` Mark Rutland
2015-07-02 10:39 ` Russell King - ARM Linux
2015-07-02 10:55 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592ACC5.4010500@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).