linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes
Date: Tue, 30 Jun 2015 18:37:00 -0700	[thread overview]
Message-ID: <5593443C.5070800@codeaurora.org> (raw)
In-Reply-To: <1435699387-32591-1-git-send-email-timur@codeaurora.org>

On 06/30/2015 02:23 PM, Timur Tabi wrote:
> From: Shanker Donthineni <shankerd@codeaurora.org>
>
> Some debuggers, such as Trace32 from Lauterbach GmbH, do not handle
> reads/writes from/to DCC on secondary cores.  Each core has its
> own DCC device registers, so when a core reads or writes from/to DCC,
> it only accesses its own DCC device.  Since kernel code can run on
> any core, every time the kernel wants to write to the console, it
> might write to a different DCC.
>
> In SMP mode, Trace32 only uses the DCC on core 0.  In AMP mode, it
> creates multiple windows, and each window shows the DCC output
> only from that core's DCC.  The result is that console output is
> either lost or scattered across windows.
>
> Selecting this option will enable code that serializes all console
> input and output to core 0.  The DCC driver will create input and
> output FIFOs that all cores will use.  Reads and writes from/to DCC
> are handled by a workqueue that runs only core 0.
>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> Acked-by: Adam Wallis <awallis@codeaurora.org>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---

Maybe we should look into making the console number (i.e. ttyHVC0,
ttyHVC1, etc.) correspond to the logical CPU number 0, 1, etc? We would
need some hotplug notifier to tear down and restore the console when the
CPU comes online and goes offline, but it may work out nicer than taking
the approach this patch does.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-07-01  1:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 21:23 [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Timur Tabi
2015-06-30 21:23 ` [PATCH 2/4] hvc_dcc: don't ignore errors during initialization Timur Tabi
2015-07-01 23:54   ` Stephen Boyd
2015-07-03 14:46     ` Timur Tabi
2015-06-30 21:23 ` [PATCH 3/4] [v3] ARM64: TTY: hvc_dcc: Add support for ARM64 dcc Timur Tabi
2015-06-30 21:23 ` [PATCH 4/4] hvc_dcc: disable user-space access to DCC Timur Tabi
2015-07-02  0:00   ` Stephen Boyd
2015-07-03 14:53     ` Timur Tabi
2015-07-01  1:37 ` Stephen Boyd [this message]
2015-07-01  1:57   ` [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Timur Tabi
2015-07-01 23:38     ` Stephen Boyd
2015-07-03 14:42       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5593443C.5070800@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).