linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes
Date: Tue, 30 Jun 2015 20:57:45 -0500	[thread overview]
Message-ID: <55934919.8070703@codeaurora.org> (raw)
In-Reply-To: <5593443C.5070800@codeaurora.org>

Stephen Boyd wrote:
> Maybe we should look into making the console number (i.e. ttyHVC0,
> ttyHVC1, etc.) correspond to the logical CPU number 0, 1, etc? We would
> need some hotplug notifier to tear down and restore the console when the
> CPU comes online and goes offline, but it may work out nicer than taking
> the approach this patch does.

My understanding is that Trace32 only responds to core 0 in SMP mode. 
So if CPU0 goes offline, there's no point in migrating the thread to 
another CPU, because Trace32 won't listen for it anyway.  Without this 
patch, console output is randomly scattered across CPUs because the 
put_chars call run on any CPU.  Without consolidating all console output 
to one CPU, DCC is effectively useless.

So I can make the changes you suggested, but I don't think that actually 
fixes anything.  When CPU0 goes offline, what does schedule_work_on(0, 
actually do?  If it does nothing, then the output FIFO will fill up, and 
put_chars will return 0, and that's it.

Does CPU hotplug automatically take CPUs offline when the load is low? 
If so, then then thread could randomly bounce from CPU to CPU.

Last I checked, ARM64 ACPI does not support discontiguous CPUs, so the 
boot CPU is always core "0".

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

  reply	other threads:[~2015-07-01  1:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 21:23 [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Timur Tabi
2015-06-30 21:23 ` [PATCH 2/4] hvc_dcc: don't ignore errors during initialization Timur Tabi
2015-07-01 23:54   ` Stephen Boyd
2015-07-03 14:46     ` Timur Tabi
2015-06-30 21:23 ` [PATCH 3/4] [v3] ARM64: TTY: hvc_dcc: Add support for ARM64 dcc Timur Tabi
2015-06-30 21:23 ` [PATCH 4/4] hvc_dcc: disable user-space access to DCC Timur Tabi
2015-07-02  0:00   ` Stephen Boyd
2015-07-03 14:53     ` Timur Tabi
2015-07-01  1:37 ` [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Stephen Boyd
2015-07-01  1:57   ` Timur Tabi [this message]
2015-07-01 23:38     ` Stephen Boyd
2015-07-03 14:42       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55934919.8070703@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).