From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Wed, 01 Jul 2015 17:14:39 -0700 Subject: [PATCH v2 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver In-Reply-To: References: <1435783930-20184-1-git-send-email-ariel@vanguardiasur.com.ar> <1435783930-20184-2-git-send-email-ariel@vanguardiasur.com.ar> Message-ID: <5594826F.6090203@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/01/2015 04:04 PM, Joachim Eastwood wrote: > Hi Ariel, > >> +/* >> + * NXP LPC18xx Watchdog Timer (WDT) > > I think you should use "Windowed Watchdog Timer (WWDT)" here since > that is name from the user manual, even though the driver doesn't have > window functionality. > At least use wwdt for the compatible string, ie: "nxp,lpc1850-wwdt". > > I don't think Guenter asked you to remove the "Windowed" part last > time, but only asked what it meant. I did, separately, but I don't want to start a war of words either. No one will know what that term means, and I am personally not too hot having to explain it to others. If you insist using the term, please add a comment into the code explaining what it is and that the driver does not support it. Guenter