From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support
Date: Thu, 2 Jul 2015 15:52:49 +0300 [thread overview]
Message-ID: <55953421.30009@ti.com> (raw)
In-Reply-To: <20150702122337.GE5837@saruman.tx.rr.com>
On 07/02/2015 03:23 PM, Felipe Balbi wrote:
> On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote:
>> The sound support consist only Headset output on the board and can be
>> handled by "simple-audio-card"
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Still works fine:
>
> Tested-by: Felipe Balbi <balbi@ti.com>
>
> one question though, should Line In be listed below ?
Does the board have Line-in? I don't have the board, but I know this patch
works on it ;)
We only had playback path before also.
> Also, unrelated to
> $subject, but if I wait for a few seconds between runs of speaker-test
> (iow, if I allow mcasp to idle) then I hear a slight chopping sound when
> starting, perhaps we're unmuting too early ?
Is it only with this patch (via simple-card) or was it the same via the
davinci-evm (ti,da830-evm-audio)?
--
P?ter
>
>> ---
>> arch/arm/boot/dts/am437x-sk-evm.dts | 30 ++++++++++++++++++++++--------
>> 1 file changed, 22 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
>> index b5de6b0d622c..e09216cb14df 100644
>> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
>> @@ -32,14 +32,26 @@
>> };
>>
>> sound {
>> - compatible = "ti,da830-evm-audio";
>> - ti,model = "AM437x-SK-EVM";
>> - ti,audio-codec = <&tlv320aic3106>;
>> - ti,mcasp-controller = <&mcasp1>;
>> - ti,codec-clock-rate = <24000000>;
>> - ti,audio-routing =
>> - "Headphone Jack", "HPLOUT",
>> - "Headphone Jack", "HPROUT";
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "AM437x-SK-EVM";
>> + simple-audio-card,widgets =
>> + "Headphone", "Headphone Jack";
>> + simple-audio-card,routing =
>> + "Headphone Jack", "HPLOUT",
>> + "Headphone Jack", "HPROUT";
>> + simple-audio-card,format = "dsp_b";
>> + simple-audio-card,bitclock-master = <&sound_master>;
>> + simple-audio-card,frame-master = <&sound_master>;
>> + simple-audio-card,bitclock-inversion;
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&mcasp1>;
>> + };
>> +
>> + sound_master: simple-audio-card,codec {
>> + sound-dai = <&tlv320aic3106>;
>> + system-clock-frequency = <24000000>;
>> + };
>> };
>>
>> matrix_keypad: matrix_keypad at 0 {
>> @@ -489,6 +501,7 @@
>> };
>>
>> tlv320aic3106: tlv320aic3106 at 1b {
>> + #sound-dai-cells = <0>;
>> compatible = "ti,tlv320aic3106";
>> reg = <0x1b>;
>> status = "okay";
>> @@ -649,6 +662,7 @@
>> };
>>
>> &mcasp1 {
>> + #sound-dai-cells = <0>;
>> pinctrl-names = "default", "sleep";
>> pinctrl-0 = <&mcasp1_pins>;
>> pinctrl-1 = <&mcasp1_pins_sleep>;
>> --
>> 2.4.5
>>
>
next prev parent reply other threads:[~2015-07-02 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 11:58 [PATCH 0/2] ARM: DTS: am437x-sk-evm: Use simple-card for audio support Peter Ujfalusi
2015-07-02 11:58 ` [PATCH 1/2] ARM: DTS: am437x-sk-evm: Add sleep pin settings for mcasp1 Peter Ujfalusi
2015-07-02 12:16 ` Felipe Balbi
2015-07-02 11:58 ` [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support Peter Ujfalusi
2015-07-02 12:23 ` Felipe Balbi
2015-07-02 12:52 ` Peter Ujfalusi [this message]
2015-07-02 13:19 ` Felipe Balbi
2015-07-02 12:10 ` [PATCH 0/2] ARM: DTS: am437x-sk-evm: Use simple-card " Felipe Balbi
2015-07-02 12:55 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55953421.30009@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).