linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cory.tusar@pid1solutions.com (Cory Tusar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/7] ARM: dts: vfxxx: Include support for qspi1 functionality.
Date: Thu, 02 Jul 2015 12:49:02 -0400	[thread overview]
Message-ID: <55956B7E.9010606@pid1solutions.com> (raw)
In-Reply-To: <0d7c39d4b78fec56adc8a8d66301a3ad@agner.ch>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/02/2015 09:44 AM, Stefan Agner wrote:
> On 2015-07-01 22:20, Cory Tusar wrote:
>> This commit extends the existing Vybrid QSPI devicetree implementation
>> to also describe the qspi1 functional block.
>>
>> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
>> ---
>>  arch/arm/boot/dts/vfxxx.dtsi | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
>> index 089a263..a7c370e 100644
>> --- a/arch/arm/boot/dts/vfxxx.dtsi
>> +++ b/arch/arm/boot/dts/vfxxx.dtsi
>> @@ -251,6 +251,19 @@
>>  				status = "disabled";
>>  			};
>>  
>> +			qspi1: quadspi at 400c4000 {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +				compatible = "fsl,vf610-qspi";
>> +				reg = <0x400c4000 0x1000>, <0x50000000 0x10000000>;
>> +				reg-names = "QuadSPI", "QuadSPI-memory";
>> +				interrupts = <25 IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&clks VF610_CLK_QSPI1_EN>,
>> +					<&clks VF610_CLK_QSPI1>;
>> +				clock-names = "qspi_en", "qspi";
>> +				status = "disabled";
>> +			};
>> +
>>  			iomuxc: iomuxc at 40048000 {
>>  				compatible = "fsl,vf610-iomuxc";
>>  				reg = <0x40048000 0x1000>;
> 
> This seem to be at the wrong place under aips0. qspi1 should be under
> aips1. just before fec0. But other than that, I checked the addresses
> looks good to me. Hence with that change applied you can include:
> 
> Reviewed-by: Stefan Agner <stefan@agner.ch>

Hi Stefan,

Thanks for the review.  Will update for the next version.

You'd think I would've checked that after making the same goof with
i2c... :/

- -Cory


- -- 
Cory Tusar
Principal
PID 1 Solutions, Inc.


"There are two ways of constructing a software design.  One way is to
 make it so simple that there are obviously no deficiencies, and the
 other way is to make it so complicated that there are no obvious
 deficiencies."  --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlWVa34ACgkQHT1tsfGwHJ/yCwCfU0jadwpYzOmZ86jDqSvtht+A
XvkAoKqfQJQmwVSibjxRDe57DcCWYlXd
=+QPB
-----END PGP SIGNATURE-----

  reply	other threads:[~2015-07-02 16:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 20:20 [RFC PATCH 0/7] fsl-quadspi: Allow additional device combinations Cory Tusar
2015-07-01 20:20 ` [RFC PATCH 1/7] ARM: dts: vf610: Add missing QuadSPI register mapping and names Cory Tusar
2015-07-02 13:34   ` Stefan Agner
2015-07-01 20:20 ` [RFC PATCH 2/7] ARM: dts: vfxxx: Include support for qspi1 functionality Cory Tusar
2015-07-02 13:44   ` Stefan Agner
2015-07-02 16:49     ` Cory Tusar [this message]
2015-07-01 20:20 ` [RFC PATCH 3/7] mtd: fsl-quadspi: Support both 24- and 32-bit addressed commands Cory Tusar
2015-07-01 20:20 ` [RFC PATCH 4/7] mtd: fsl-quadspi: Use per-device clk_rate Cory Tusar
2015-07-01 20:20 ` [RFC PATCH 5/7] mtd: fsl-quadspi: Allow non-contiguous flash layouts Cory Tusar
2015-07-01 20:20 ` [RFC PATCH 6/7] mtd: spi-nor: Add support for Micron MT25QL02GC serial flash Cory Tusar
2015-07-01 20:20 ` [RFC PATCH 7/7] ARM: dts: vf610-twr: Enable QSPI and map flash devices Cory Tusar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55956B7E.9010606@pid1solutions.com \
    --to=cory.tusar@pid1solutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).