* [PATCH] clk: mvebu: update cpu clock frequency @ 2015-07-02 19:42 Gregory CLEMENT 2015-07-02 20:04 ` Andrew Lunn 0 siblings, 1 reply; 3+ messages in thread From: Gregory CLEMENT @ 2015-07-02 19:42 UTC (permalink / raw) To: linux-arm-kernel Since u-boot 2015_T1.0p6 there are new requency settings available. Based on a patch from Nadav Haklai <nadavh@marvell.com> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> --- drivers/clk/mvebu/armada-38x.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c index 8bccf4ecdab6..c64037e2e89f 100644 --- a/drivers/clk/mvebu/armada-38x.c +++ b/drivers/clk/mvebu/armada-38x.c @@ -46,10 +46,11 @@ static u32 __init armada_38x_get_tclk_freq(void __iomem *sar) } static const u32 armada_38x_cpu_frequencies[] __initconst = { - 0, 0, 0, 0, - 1066 * 1000 * 1000, 0, 0, 0, + 666 * 1000 * 1000, 0, 800 * 1000 * 1000, 0, + 1066 * 1000 * 1000, 0, 1200 * 1000 * 1000, 0, 1332 * 1000 * 1000, 0, 0, 0, - 1600 * 1000 * 1000, + 1600 * 1000 * 1000, 0, 0, 0, + 1866 * 1000 * 1000, 0, 0, 2000 * 1000 * 1000, }; static u32 __init armada_38x_get_cpu_freq(void __iomem *sar) -- 2.1.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] clk: mvebu: update cpu clock frequency 2015-07-02 19:42 [PATCH] clk: mvebu: update cpu clock frequency Gregory CLEMENT @ 2015-07-02 20:04 ` Andrew Lunn 2015-07-02 20:21 ` Gregory CLEMENT 0 siblings, 1 reply; 3+ messages in thread From: Andrew Lunn @ 2015-07-02 20:04 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 02, 2015 at 09:42:38PM +0200, Gregory CLEMENT wrote: > Since u-boot 2015_T1.0p6 there are new requency settings available. Hi Gregory Missing f in f_requency. Also, what has u-boot got to do with this? I would expect this is a property of the hardware. What happens is an older u-boot is used? Thanks Andrew > > Based on a patch from Nadav Haklai <nadavh@marvell.com> > > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > --- > drivers/clk/mvebu/armada-38x.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c > index 8bccf4ecdab6..c64037e2e89f 100644 > --- a/drivers/clk/mvebu/armada-38x.c > +++ b/drivers/clk/mvebu/armada-38x.c > @@ -46,10 +46,11 @@ static u32 __init armada_38x_get_tclk_freq(void __iomem *sar) > } > > static const u32 armada_38x_cpu_frequencies[] __initconst = { > - 0, 0, 0, 0, > - 1066 * 1000 * 1000, 0, 0, 0, > + 666 * 1000 * 1000, 0, 800 * 1000 * 1000, 0, > + 1066 * 1000 * 1000, 0, 1200 * 1000 * 1000, 0, > 1332 * 1000 * 1000, 0, 0, 0, > - 1600 * 1000 * 1000, > + 1600 * 1000 * 1000, 0, 0, 0, > + 1866 * 1000 * 1000, 0, 0, 2000 * 1000 * 1000, > }; > > static u32 __init armada_38x_get_cpu_freq(void __iomem *sar) > -- > 2.1.0 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] clk: mvebu: update cpu clock frequency 2015-07-02 20:04 ` Andrew Lunn @ 2015-07-02 20:21 ` Gregory CLEMENT 0 siblings, 0 replies; 3+ messages in thread From: Gregory CLEMENT @ 2015-07-02 20:21 UTC (permalink / raw) To: linux-arm-kernel Hi Andrew, thanks for your prompt review On 02/07/2015 22:04, Andrew Lunn wrote: > On Thu, Jul 02, 2015 at 09:42:38PM +0200, Gregory CLEMENT wrote: >> Since u-boot 2015_T1.0p6 there are new requency settings available. > > Hi Gregory > > Missing f in f_requency. it must have been lost in the copy and paste I will fix it. > > Also, what has u-boot got to do with this? I would expect this is a > property of the hardware. What happens is an older u-boot is used? As you probably know, a lot of "magical" initialization is done in the U-boot from Marvell. So maybe is it the reason why u-boot was mentioned. However you're right I will ask more information about especially if it is safe to have this value with an older u-boot. Thanks, Gregory > > Thanks > Andrew > >> >> Based on a patch from Nadav Haklai <nadavh@marvell.com> >> >> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> >> --- >> drivers/clk/mvebu/armada-38x.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c >> index 8bccf4ecdab6..c64037e2e89f 100644 >> --- a/drivers/clk/mvebu/armada-38x.c >> +++ b/drivers/clk/mvebu/armada-38x.c >> @@ -46,10 +46,11 @@ static u32 __init armada_38x_get_tclk_freq(void __iomem *sar) >> } >> >> static const u32 armada_38x_cpu_frequencies[] __initconst = { >> - 0, 0, 0, 0, >> - 1066 * 1000 * 1000, 0, 0, 0, >> + 666 * 1000 * 1000, 0, 800 * 1000 * 1000, 0, >> + 1066 * 1000 * 1000, 0, 1200 * 1000 * 1000, 0, >> 1332 * 1000 * 1000, 0, 0, 0, >> - 1600 * 1000 * 1000, >> + 1600 * 1000 * 1000, 0, 0, 0, >> + 1866 * 1000 * 1000, 0, 0, 2000 * 1000 * 1000, >> }; >> >> static u32 __init armada_38x_get_cpu_freq(void __iomem *sar) >> -- >> 2.1.0 >> -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-02 20:21 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-02 19:42 [PATCH] clk: mvebu: update cpu clock frequency Gregory CLEMENT 2015-07-02 20:04 ` Andrew Lunn 2015-07-02 20:21 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).