[PATCH v2 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver

Guenter Roeck
2015-07-02T00:14:39Z

On 07/01/2015 04:04 PM, Joachim Eastwood wrote:
> Hi Ariel,
>

>> +/*
>> + * NXP LPC18xx Watchdog Timer (WDT)
>
> I think you should use "Windowed Watchdog Timer (WWDT)" here since
> that is name from the user manual, even though the driver doesn't have
> window functionality.
> At least use wwdt for the compatible string, ie: "nxp,lpc1850-wwdt".
>
> I don't think Guenter asked you to remove the "Windowed" part last
> time, but only asked what it meant.

I did, separately, but I don't want to start a war of words either.
No one will know what that term means, and I am personally not too hot
having to explain it to others.

If you insist using the term, please add a comment into the code
explaining what it is and that the driver does not support it.

Guenter