[PATCH v2 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver

Joachim Eastwood
2015-07-02T09:03:10Z

On 2 July 2015 at 02:14, Guenter Roeck <linux@roeck-us.net> wrote:
> On 07/01/2015 04:04 PM, Joachim Eastwood wrote:
>>
>> Hi Ariel,
>>
>
>>> +/*
>>> + * NXP LPC18xx Watchdog Timer (WDT)
>>
>>
>> I think you should use "Windowed Watchdog Timer (WWDT)" here since
>> that is name from the user manual, even though the driver doesn't have
>> window functionality.
>> At least use wwdt for the compatible string, ie: "nxp,lpc1850-wwdt".
>>
>> I don't think Guenter asked you to remove the "Windowed" part last
>> time, but only asked what it meant.
>
>
> I did, separately, but I don't want to start a war of words either.
> No one will know what that term means, and I am personally not too hot
> having to explain it to others.

Fine.

My only request then is to make the compatible string
"nxp,lpc1850-wwdt", to leave the WWDT name somewhere. As this is the
name you will find through out the user manual for this hw block.

regards,
Joachim Eastwood

> If you insist using the term, please add a comment into the code
> explaining what it is and that the driver does not support it.
>
> Guenter
>