* [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order
@ 2015-07-06 14:12 Chanho Park
2015-07-07 1:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Chanho Park @ 2015-07-06 14:12 UTC (permalink / raw)
To: linux-arm-kernel
The odroid-xu3 board which is based on exynos5422 not exynos5800 is
booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order
is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are
cortex-a15 cores. To correct this mis-odering, I added exynos5422.dtsi
and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and
cpu4-7 are cortex-a15.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
Changes from v4:
- Remove temporal patch in e-mail body
Changes from v3:
- include this exynos5422-cpus.dtsi in the exynos5422-odroidxu3-common.dtsi
Changes from v2:
- drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi
- drop compatibles from exynos5422-cpus.dtsi
Changes from v1:
- rename exynos5422.dtsi to exynos5422-cpus.dtsi
- include the dtsi file top of the exynos5422-odroidxu3.dts
Secondary cpu booting problem[1] is not resolved yet. Need more investigations
to work booting 8 cores correctly.
[1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html
arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
2 files changed, 82 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi
diff --git a/arch/arm/boot/dts/exynos5422-cpus.dtsi b/arch/arm/boot/dts/exynos5422-cpus.dtsi
new file mode 100644
index 0000000..b7f60c8
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5422-cpus.dtsi
@@ -0,0 +1,81 @@
+/*
+ * SAMSUNG EXYNOS5422 SoC cpu device tree source
+ *
+ * Copyright (c) 2015 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * The only difference between EXYNOS5422 and EXYNOS5800 is cpu ordering. The
+ * EXYNOS5422 is booting from Cortex-A7 core while the EXYNOS5800 is booting
+ * from Cortex-A15 core.
+ *
+ * EXYNOS5422 based board files can include this file to provide cpu ordering
+ * which could boot a cortex-a7 from cpu0.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+&cpu0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x100>;
+ clock-frequency = <1000000000>;
+ cci-control-port = <&cci_control0>;
+};
+
+&cpu1 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x101>;
+ clock-frequency = <1000000000>;
+ cci-control-port = <&cci_control0>;
+};
+
+&cpu2 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x102>;
+ clock-frequency = <1000000000>;
+ cci-control-port = <&cci_control0>;
+};
+
+&cpu3 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x103>;
+ clock-frequency = <1000000000>;
+ cci-control-port = <&cci_control0>;
+};
+
+&cpu4 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x0>;
+ clock-frequency = <1800000000>;
+ cci-control-port = <&cci_control1>;
+};
+
+&cpu5 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x1>;
+ clock-frequency = <1800000000>;
+ cci-control-port = <&cci_control1>;
+};
+
+&cpu6 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x2>;
+ clock-frequency = <1800000000>;
+ cci-control-port = <&cci_control1>;
+};
+
+&cpu7 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x3>;
+ clock-frequency = <1800000000>;
+ cci-control-port = <&cci_control1>;
+};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 8adf455..f603133 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -15,6 +15,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/sound/samsung-i2s.h>
#include "exynos5800.dtsi"
+#include "exynos5422-cpus.dtsi"
/ {
memory {
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order
2015-07-06 14:12 [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order Chanho Park
@ 2015-07-07 1:44 ` Krzysztof Kozlowski
2015-07-07 2:23 ` Krzysztof Kozlowski
2015-07-07 14:30 ` Kukjin Kim
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-07 1:44 UTC (permalink / raw)
To: linux-arm-kernel
On 06.07.2015 23:12, Chanho Park wrote:
> The odroid-xu3 board which is based on exynos5422 not exynos5800 is
> booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order
> is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are
> cortex-a15 cores. To correct this mis-odering, I added exynos5422.dtsi
> and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and
> cpu4-7 are cortex-a15.
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> Changes from v4:
> - Remove temporal patch in e-mail body
>
> Changes from v3:
> - include this exynos5422-cpus.dtsi in the exynos5422-odroidxu3-common.dtsi
>
> Changes from v2:
> - drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi
> - drop compatibles from exynos5422-cpus.dtsi
>
> Changes from v1:
> - rename exynos5422.dtsi to exynos5422-cpus.dtsi
> - include the dtsi file top of the exynos5422-odroidxu3.dts
>
> Secondary cpu booting problem[1] is not resolved yet. Need more investigations
> to work booting 8 cores correctly.
>
> [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html
>
> arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
> 2 files changed, 82 insertions(+)
> create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi
Thanks, applied to my tree. I'll sent it to Kukjin later for 4.3 unless
he picks it up from LKML.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order
2015-07-07 1:44 ` Krzysztof Kozlowski
@ 2015-07-07 2:23 ` Krzysztof Kozlowski
2015-07-07 14:30 ` Kukjin Kim
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-07 2:23 UTC (permalink / raw)
To: linux-arm-kernel
On 07.07.2015 10:44, Krzysztof Kozlowski wrote:
> On 06.07.2015 23:12, Chanho Park wrote:
>> The odroid-xu3 board which is based on exynos5422 not exynos5800 is
>> booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order
>> is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are
>> cortex-a15 cores. To correct this mis-odering, I added exynos5422.dtsi
>> and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and
>> cpu4-7 are cortex-a15.
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>> ---
>> Changes from v4:
>> - Remove temporal patch in e-mail body
>>
>> Changes from v3:
>> - include this exynos5422-cpus.dtsi in the exynos5422-odroidxu3-common.dtsi
>>
>> Changes from v2:
>> - drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi
>> - drop compatibles from exynos5422-cpus.dtsi
>>
>> Changes from v1:
>> - rename exynos5422.dtsi to exynos5422-cpus.dtsi
>> - include the dtsi file top of the exynos5422-odroidxu3.dts
>>
>> Secondary cpu booting problem[1] is not resolved yet. Need more investigations
>> to work booting 8 cores correctly.
>>
>> [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html
>>
>> arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
>> 2 files changed, 82 insertions(+)
>> create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi
>
> Thanks, applied to my tree. I'll sent it to Kukjin later for 4.3 unless
> he picks it up from LKML.
>
> Best regards,
> Krzysztof
Un-applied. The signed-off-by does not match from.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order
2015-07-07 1:44 ` Krzysztof Kozlowski
2015-07-07 2:23 ` Krzysztof Kozlowski
@ 2015-07-07 14:30 ` Kukjin Kim
2015-07-07 23:41 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2015-07-07 14:30 UTC (permalink / raw)
To: linux-arm-kernel
Krzysztof Kozlowski wrote:
>
> On 06.07.2015 23:12, Chanho Park wrote:
> > The odroid-xu3 board which is based on exynos5422 not exynos5800 is
> > booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order
> > is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are
> > cortex-a15 cores. To correct this mis-odering, I added exynos5422.dtsi
> > and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and
> > cpu4-7 are cortex-a15.
> >
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> > Changes from v4:
> > - Remove temporal patch in e-mail body
> >
> > Changes from v3:
> > - include this exynos5422-cpus.dtsi in the exynos5422-odroidxu3-common.dtsi
> >
> > Changes from v2:
> > - drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi
> > - drop compatibles from exynos5422-cpus.dtsi
> >
> > Changes from v1:
> > - rename exynos5422.dtsi to exynos5422-cpus.dtsi
> > - include the dtsi file top of the exynos5422-odroidxu3.dts
> >
> > Secondary cpu booting problem[1] is not resolved yet. Need more investigations
> > to work booting 8 cores correctly.
> >
> > [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html
> >
> > arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++
> > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
> > 2 files changed, 82 insertions(+)
> > create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi
>
> Thanks, applied to my tree. I'll sent it to Kukjin later for 4.3 unless
> he picks it up from LKML.
>
Hi Krzysztof,
If you're OK, I'd like to pick this up into Samsung tree with your ack based on
4.2-rc1.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order
2015-07-07 14:30 ` Kukjin Kim
@ 2015-07-07 23:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-07 23:41 UTC (permalink / raw)
To: linux-arm-kernel
On 07.07.2015 23:30, Kukjin Kim wrote:
> Krzysztof Kozlowski wrote:
>>
>> On 06.07.2015 23:12, Chanho Park wrote:
>>> The odroid-xu3 board which is based on exynos5422 not exynos5800 is
>>> booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order
>>> is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are
>>> cortex-a15 cores. To correct this mis-odering, I added exynos5422.dtsi
>>> and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and
>>> cpu4-7 are cortex-a15.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>>> ---
>>> Changes from v4:
>>> - Remove temporal patch in e-mail body
>>>
>>> Changes from v3:
>>> - include this exynos5422-cpus.dtsi in the exynos5422-odroidxu3-common.dtsi
>>>
>>> Changes from v2:
>>> - drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi
>>> - drop compatibles from exynos5422-cpus.dtsi
>>>
>>> Changes from v1:
>>> - rename exynos5422.dtsi to exynos5422-cpus.dtsi
>>> - include the dtsi file top of the exynos5422-odroidxu3.dts
>>>
>>> Secondary cpu booting problem[1] is not resolved yet. Need more investigations
>>> to work booting 8 cores correctly.
>>>
>>> [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html
>>>
>>> arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++
>>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
>>> 2 files changed, 82 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi
>>
>> Thanks, applied to my tree. I'll sent it to Kukjin later for 4.3 unless
>> he picks it up from LKML.
>>
> Hi Krzysztof,
>
> If you're OK, I'd like to pick this up into Samsung tree with your ack based on
> 4.2-rc1.
Yes, please go ahead. It already has my reviewed-by tag. However the sob
does not match author so it should be resent once again.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-07 23:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-06 14:12 [PATCHv5] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order Chanho Park
2015-07-07 1:44 ` Krzysztof Kozlowski
2015-07-07 2:23 ` Krzysztof Kozlowski
2015-07-07 14:30 ` Kukjin Kim
2015-07-07 23:41 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox