From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control
Date: Tue, 07 Jul 2015 09:10:36 +0200 [thread overview]
Message-ID: <559B7B6C.3060900@linaro.org> (raw)
In-Reply-To: <559ABDC5.3060200@redhat.com>
On 07/06/2015 07:41 PM, Paolo Bonzini wrote:
>
>
> On 06/07/2015 19:09, Eric Auger wrote:
>>>> The good thing is that this helps a bit forming a lock hierarchy across
>>>> the subsystems, for example irq bypass mutex outside vfio_platform_irq
>>>> spinlock, because you cannot have a spinlock inside the mutex. I think
>>>> that all of your six callbacks are fine.
>> arghh, no that's wrong then. I have plenty of them in the KVM/arm vgic
>> part :-(
>
> I checked and it's right...
>
> /me rereads
>
> AAAARGH. You cannot have a mutex inside a spinlock. What you're doing
> is fine.
Sweated up (+ heat wave in France). Was about to read again the
"concurrency and race conditions" chapter of the linux driver bible.
Might be worth anyway ;-)
Many thanks for the review
Eric
>
> Paolo
>
next prev parent reply other threads:[~2015-07-07 7:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 12:11 [RFC v2 0/6] IRQ bypass manager and irqfd consumer Eric Auger
2015-07-06 12:11 ` [RFC v2 1/6] KVM: arm/arm64: select IRQ_BYPASS_MANAGER Eric Auger
2015-07-06 12:24 ` Paolo Bonzini
2015-07-06 12:11 ` [RFC v2 2/6] VFIO: platform: " Eric Auger
2015-07-06 12:11 ` [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control Eric Auger
2015-07-06 12:27 ` Paolo Bonzini
2015-07-06 15:35 ` Eric Auger
2015-07-06 15:57 ` Paolo Bonzini
2015-07-06 17:09 ` Eric Auger
2015-07-06 17:41 ` Paolo Bonzini
2015-07-07 7:10 ` Eric Auger [this message]
2015-07-07 8:58 ` Paolo Bonzini
2015-07-07 10:58 ` Wu, Feng
2015-07-07 11:00 ` Paolo Bonzini
2015-07-07 11:13 ` Wu, Feng
2015-07-07 11:13 ` Paolo Bonzini
2015-07-07 11:18 ` Wu, Feng
2015-07-07 11:21 ` Paolo Bonzini
2015-07-07 11:24 ` Wu, Feng
2015-07-07 11:33 ` Wu, Feng
2015-07-07 13:22 ` Paolo Bonzini
2015-07-06 12:11 ` [RFC v2 4/6] KVM: create kvm_irqfd.h Eric Auger
2015-07-06 12:11 ` [RFC v2 5/6] KVM: introduce kvm_arch functions for IRQ bypass Eric Auger
2015-07-06 12:11 ` [RFC v2 6/6] KVM: eventfd: add irq bypass consumer management Eric Auger
2015-07-07 8:47 ` Wu, Feng
2015-07-07 9:05 ` Eric Auger
2015-07-07 9:13 ` Wu, Feng
2015-07-07 17:17 ` [RFC v2 0/6] IRQ bypass manager and irqfd consumer Alex Williamson
2015-07-09 12:28 ` Joerg Roedel
2015-07-09 14:13 ` Alex Williamson
2015-07-09 14:38 ` Paolo Bonzini
2015-07-09 15:34 ` Joerg Roedel
2015-07-09 16:06 ` Alex Williamson
2015-07-24 1:27 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B7B6C.3060900@linaro.org \
--to=eric.auger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).