From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator
Date: Thu, 16 Jul 2015 09:45:20 +0900 [thread overview]
Message-ID: <55A6FEA0.8090202@samsung.com> (raw)
In-Reply-To: <1436977965-7078-2-git-send-email-javier@osg.samsung.com>
On 16.07.2015 01:32, Javier Martinez Canillas wrote:
> The Maxim max77802 Power Management IC has besides other devices, a set of
> regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802
> regulator, rtc and clock drivers") was supposed to enable the config option
> for the regulator driver as a module but the final version that landed did
> not include this. So this patch enables the needed Kconfig option.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Please describe why do you want to enable it (IOW who will benefit from
enabling it?). This symbol was removed by Kukjin from your commit:
[kgene at kernel.org: removing useless REGULATOR_MAX77802 config]
so justification would be welcomed.
Beside the commit description I agree with the patch.
Best regards,
Krzysztof
> ---
>
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 4b93761d58d2..b07493997993 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -402,6 +402,7 @@ CONFIG_REGULATOR_MAX14577=m
> CONFIG_REGULATOR_MAX8907=y
> CONFIG_REGULATOR_MAX8973=y
> CONFIG_REGULATOR_MAX77686=y
> +CONFIG_REGULATOR_MAX77802=m
> CONFIG_REGULATOR_MAX77693=m
> CONFIG_REGULATOR_PALMAS=y
> CONFIG_REGULATOR_S2MPS11=y
>
next prev parent reply other threads:[~2015-07-16 0:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:32 [PATCH 0/3] ARM: Enable NTC Thermistors and max77802 regulator drivers Javier Martinez Canillas
2015-07-15 16:32 ` [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator Javier Martinez Canillas
2015-07-16 0:45 ` Krzysztof Kozlowski [this message]
2015-07-16 5:44 ` Javier Martinez Canillas
2015-07-16 6:16 ` Krzysztof Kozlowski
2015-07-15 16:32 ` [PATCH 2/3] ARM: multi_v7_defconfig: Enable NTC Thermistors support Javier Martinez Canillas
2015-07-16 0:48 ` Krzysztof Kozlowski
2015-07-15 16:32 ` [PATCH 3/3] ARM: exynos_defconfig: " Javier Martinez Canillas
2015-07-16 0:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A6FEA0.8090202@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).