From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator
Date: Thu, 16 Jul 2015 07:44:41 +0200 [thread overview]
Message-ID: <55A744C9.6040703@osg.samsung.com> (raw)
In-Reply-To: <55A6FEA0.8090202@samsung.com>
Hello Krzysztof,
Thanks for the feedback.
On 07/16/2015 02:45 AM, Krzysztof Kozlowski wrote:
> On 16.07.2015 01:32, Javier Martinez Canillas wrote:
>> The Maxim max77802 Power Management IC has besides other devices, a set of
>> regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802
>> regulator, rtc and clock drivers") was supposed to enable the config option
>> for the regulator driver as a module but the final version that landed did
>> not include this. So this patch enables the needed Kconfig option.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Please describe why do you want to enable it (IOW who will benefit from
> enabling it?). This symbol was removed by Kukjin from your commit:
> [kgene at kernel.org: removing useless REGULATOR_MAX77802 config]
> so justification would be welcomed.
>
You are right, sorry for not making the commit message clear. This PMIC
is used by a couple of Exynos5 based boars such as the Peach Pit and Pi
Chromebooks. I expect it to be found in other designs too just like the
max77686 is found in many Exynos5 based boards.
I'll add this to the commit message on v2.
> Beside the commit description I agree with the patch.
>
Does this mean I can add your Reviewed-by to this patch as well?
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-07-16 5:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:32 [PATCH 0/3] ARM: Enable NTC Thermistors and max77802 regulator drivers Javier Martinez Canillas
2015-07-15 16:32 ` [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator Javier Martinez Canillas
2015-07-16 0:45 ` Krzysztof Kozlowski
2015-07-16 5:44 ` Javier Martinez Canillas [this message]
2015-07-16 6:16 ` Krzysztof Kozlowski
2015-07-15 16:32 ` [PATCH 2/3] ARM: multi_v7_defconfig: Enable NTC Thermistors support Javier Martinez Canillas
2015-07-16 0:48 ` Krzysztof Kozlowski
2015-07-15 16:32 ` [PATCH 3/3] ARM: exynos_defconfig: " Javier Martinez Canillas
2015-07-16 0:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A744C9.6040703@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).