* [PATCH] ARM: zynq: reserve space for jump target in secondary trampoline
@ 2015-07-17 21:01 Nathan Lynch
2015-07-20 8:43 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Lynch @ 2015-07-17 21:01 UTC (permalink / raw)
To: linux-arm-kernel
Add a zero argument to the .word directive in
zynq_secondary_trampoline. Without an expression the assembler emits
nothing for the .word directive.
This makes it so that the intended range is communicated to ioremap
and outer_flush_range in zynq_cpun_start; e.g. for LE
trampoline_code_size evaluates to 12 now instead of 8.
Found by inspection. I'm not aware of any real problem this fixes.
Tested by doing on online/offline loop on ZC702.
Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
---
arch/arm/mach-zynq/headsmp.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-zynq/headsmp.S b/arch/arm/mach-zynq/headsmp.S
index 045c72720a4d..f6d5de073e34 100644
--- a/arch/arm/mach-zynq/headsmp.S
+++ b/arch/arm/mach-zynq/headsmp.S
@@ -18,7 +18,7 @@ ARM_BE8(rev r0, r0)
.globl zynq_secondary_trampoline_jump
zynq_secondary_trampoline_jump:
/* Space for jumping address */
- .word /* cpu 1 */
+ .word 0 /* cpu 1 */
.globl zynq_secondary_trampoline_end
zynq_secondary_trampoline_end:
ENDPROC(zynq_secondary_trampoline)
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: zynq: reserve space for jump target in secondary trampoline
2015-07-17 21:01 [PATCH] ARM: zynq: reserve space for jump target in secondary trampoline Nathan Lynch
@ 2015-07-20 8:43 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2015-07-20 8:43 UTC (permalink / raw)
To: linux-arm-kernel
On 07/17/2015 11:01 PM, Nathan Lynch wrote:
> Add a zero argument to the .word directive in
> zynq_secondary_trampoline. Without an expression the assembler emits
> nothing for the .word directive.
>
> This makes it so that the intended range is communicated to ioremap
> and outer_flush_range in zynq_cpun_start; e.g. for LE
> trampoline_code_size evaluates to 12 now instead of 8.
>
> Found by inspection. I'm not aware of any real problem this fixes.
> Tested by doing on online/offline loop on ZC702.
>
> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
> ---
> arch/arm/mach-zynq/headsmp.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zynq/headsmp.S b/arch/arm/mach-zynq/headsmp.S
> index 045c72720a4d..f6d5de073e34 100644
> --- a/arch/arm/mach-zynq/headsmp.S
> +++ b/arch/arm/mach-zynq/headsmp.S
> @@ -18,7 +18,7 @@ ARM_BE8(rev r0, r0)
> .globl zynq_secondary_trampoline_jump
> zynq_secondary_trampoline_jump:
> /* Space for jumping address */
> - .word /* cpu 1 */
> + .word 0 /* cpu 1 */
> .globl zynq_secondary_trampoline_end
> zynq_secondary_trampoline_end:
> ENDPROC(zynq_secondary_trampoline)
>
Tested and applied to zynq/cleanup.
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-20 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 21:01 [PATCH] ARM: zynq: reserve space for jump target in secondary trampoline Nathan Lynch
2015-07-20 8:43 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).