From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] pinctrl: sunxi: Implement proper irq DT parsing
Date: Mon, 20 Jul 2015 17:38:48 +0200 [thread overview]
Message-ID: <55AD1608.7000302@redhat.com> (raw)
In-Reply-To: <1437396074-15791-1-git-send-email-maxime.ripard@free-electrons.com>
Hi,
On 20-07-15 14:41, Maxime Ripard wrote:
> Hi,
>
> So far the GPIO and pinctrl driver had a limited support for
> interrupts, and no documentation about the DT bindings. A few DT ended
> up using these external interrupts, relying on the default DT parsing
> logic.
>
> However, this doesn't really work, since there's still no
> documentation describing the expected behaviour, and we ended up with
> bindings different if you want to use a GPIO as interrupt (using the
> gpios property), or an interrupt over a GPIO (using the interrupts
> property) that doesn't really make sense and only brings confusion.
>
> Moreover, the "new" SoCs from Allwinner have multiple interrupt banks,
> while the previous generation had only one, which means that we cannot
> really express those interrupts with the default bindings anymore
> either.
>
> The point of this serie is to fix the current situation by introducing
> some custom DT parsing code to have a consistant binding with the GPIO
> one, which will also fix the multiple banks issues, and document it.
>
> Let me know what you think,
> Maxime
Series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> Maxime Ripard (4):
> pinctrl: sunxi: Use common functions to change irq_chip and handler
> pinctrl: sunxi: Add irq_chip name
> pinctrl: sunxi: Add custom irq_domain_ops
> ARM: sunxi: dt: Convert users to the PIO interrupts binding
>
> .../bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 37 ++++++++++++++-
> arch/arm/boot/dts/sun4i-a10.dtsi | 3 +-
> arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 2 +-
> arch/arm/boot/dts/sun5i.dtsi | 3 +-
> arch/arm/boot/dts/sun6i-a31.dtsi | 3 +-
> arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 2 +-
> arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts | 2 +-
> arch/arm/boot/dts/sun7i-a20.dtsi | 3 +-
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 3 +-
> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 55 +++++++++++++++++-----
> 10 files changed, 88 insertions(+), 25 deletions(-)
>
prev parent reply other threads:[~2015-07-20 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 12:41 [PATCH 0/4] pinctrl: sunxi: Implement proper irq DT parsing Maxime Ripard
2015-07-20 12:41 ` [PATCH 1/4] pinctrl: sunxi: Use common functions to change irq_chip and handler Maxime Ripard
2015-07-27 11:59 ` Linus Walleij
2015-07-20 12:41 ` [PATCH 2/4] pinctrl: sunxi: Add irq_chip name Maxime Ripard
2015-07-27 12:00 ` Linus Walleij
2015-07-20 12:41 ` [PATCH 3/4] pinctrl: sunxi: Add custom irq_domain_ops Maxime Ripard
2015-07-27 12:04 ` Linus Walleij
2015-07-27 12:27 ` Maxime Ripard
2015-07-20 12:41 ` [PATCH 4/4] ARM: sunxi: dt: Convert users to the PIO interrupts binding Maxime Ripard
2015-07-20 15:38 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD1608.7000302@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).