From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: xilinx: Add check for MSI interrupt flag before handling as INTx
Date: Tue, 21 Jul 2015 18:31:47 +0200 [thread overview]
Message-ID: <55AE73F3.8050600@xilinx.com> (raw)
In-Reply-To: <20150721154000.GA21967@google.com>
Hi Bjorn,
On 07/21/2015 05:40 PM, Bjorn Helgaas wrote:
> On Tue, Jul 07, 2015 at 05:54:19PM +0100, Russell Joyce wrote:
>> Occasionally both MSI and INTx bits in the interrupt decode register are
>> set at once by the Xilinx AXI PCIe Bridge, so the MSI flag in the
>> interrupt message should be checked to ensure that the correct handler is
>> used.
>>
>> If this check is not in place and the interrupt message type is MSI, the
>> INTx handler will be used erroneously when both type bits are set.
>> This will also be followed by a second read of the message FIFO, which can
>> result in the function returning early and the interrupt decode register
>> not being cleared if the FIFO is now empty.
>>
>> Signed-off-by: Russell Joyce <russell.joyce@york.ac.uk>
>
> Applied to pci/host-xilinx for v4.3, thanks.
>
> Xilinx guys, speak up if there's any issue with this.
I had 2 weeks off and still catching on emails. I will try to test this
and let you know if there is any problem.
Thanks,
Michal
prev parent reply other threads:[~2015-07-21 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 16:54 [PATCH] PCI: xilinx: Add check for MSI interrupt flag before handling as INTx Russell Joyce
2015-07-14 22:24 ` Bjorn Helgaas
2015-07-17 10:41 ` Russell Joyce
2015-07-21 15:40 ` Bjorn Helgaas
2015-07-21 16:31 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE73F3.8050600@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).