From: rnayak@codeaurora.org (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM
Date: Thu, 23 Jul 2015 14:05:48 +0530 [thread overview]
Message-ID: <55B0A764.6010708@codeaurora.org> (raw)
In-Reply-To: <55B03D65.8040207@codeaurora.org>
[]..
>> +
>> +#ifndef CONFIG_PM
>> +static void enable_clock(struct device *dev, const char *con_id)
>> +{
>> + struct clk *clk;
>> +
>> + clk = clk_get(dev, con_id);
>> + if (!IS_ERR(clk)) {
>> + clk_prepare_enable(clk);
>> + clk_put(clk);
>> + }
>> +}
>> +
>> +static void disable_clock(struct device *dev, const char *con_id)
>> +{
>> + struct clk *clk;
>> +
>> + clk = clk_get(dev, con_id);
>> + if (!IS_ERR(clk)) {
>> + clk_disable_unprepare(clk);
>> + clk_put(clk);
>> + }
>> +}
>
> Is there a reason why this whole patch isn't generic code? I recall some
> discussion but I forgot now and there isn't any mention of why this
> isn't generic code in the commit text.
If by generic code, you mean using PM clocks, then this thread should
give some context..
http://www.spinics.net/lists/arm-kernel/msg414072.html
next prev parent reply other threads:[~2015-07-23 8:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 7:10 [PATCH v6 00/13] qcom: Add support for GDSCs Rajendra Nayak
2015-07-22 7:10 ` [PATCH v6 01/13] clk: " Rajendra Nayak
2015-07-23 0:25 ` Stephen Boyd
2015-07-23 8:37 ` Rajendra Nayak
2015-07-23 9:09 ` Stanimir Varbanov
2015-07-23 18:04 ` Stephen Boyd
2015-07-22 7:10 ` [PATCH v6 02/13] clk: qcom: gdsc: Prepare common clk probe to register gdscs Rajendra Nayak
2015-07-23 0:27 ` Stephen Boyd
2015-07-22 7:10 ` [PATCH v6 03/13] clk: qcom: gdsc: Use PM clocks to control gdsc clocks Rajendra Nayak
2015-07-23 1:01 ` Stephen Boyd
2015-07-23 8:34 ` Rajendra Nayak
2015-07-23 9:22 ` Stanimir Varbanov
2015-07-23 10:28 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM Rajendra Nayak
2015-07-23 1:03 ` Stephen Boyd
2015-07-23 8:35 ` Rajendra Nayak [this message]
2015-07-29 1:04 ` Stephen Boyd
2015-07-29 4:37 ` Rajendra Nayak
2015-07-30 0:13 ` Stephen Boyd
2015-07-30 1:39 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 05/13] clk: qcom: gdsc: Enable an RCG before turing on the gdsc Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 06/13] clk: qcom: gdsc: Add support for Memory RET/OFF Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 07/13] clk: qcom: gdsc: Add support for ON only state Rajendra Nayak
2015-07-23 1:11 ` Stephen Boyd
2015-07-22 7:11 ` [PATCH v6 08/13] clk: qcom: gdsc: Add GDSCs in msm8916 GCC Rajendra Nayak
2015-07-23 1:07 ` Stephen Boyd
2015-07-23 8:36 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 09/13] clk: qcom: gdsc: Add GDSCs in msm8974 GCC Rajendra Nayak
2015-07-23 1:08 ` Stephen Boyd
2015-07-22 7:11 ` [PATCH v6 10/13] clk: qcom: gdsc: Add GDSCs in msm8974 MMCC Rajendra Nayak
2015-07-23 1:09 ` Stephen Boyd
2015-07-22 7:11 ` [PATCH v6 11/13] clk: qcom: gdsc: Add GDSCs in apq8084 GCC Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 12/13] clk: qcom: gdsc: Add GDSCs in apq8084 MMCC Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 13/13] arm: dts: qcom: Add #power-domain-cells property Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0A764.6010708@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).