* [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree
@ 2015-07-27 8:04 Shawn Lin
2015-07-27 8:23 ` Michal Simek
2015-07-27 15:19 ` Lars-Peter Clausen
0 siblings, 2 replies; 6+ messages in thread
From: Shawn Lin @ 2015-07-27 8:04 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds the interface to get quirks from dts, and
there is no need to assign different quirks by condition statement
of arasan IP version.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index ef5a7d2..db07788 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -132,6 +132,7 @@ static SIMPLE_DEV_PM_OPS(sdhci_arasan_dev_pm_ops, sdhci_arasan_suspend,
static int sdhci_arasan_probe(struct platform_device *pdev)
{
int ret;
+ u32 quirktab[2];
struct clk *clk_xin;
struct sdhci_host *host;
struct sdhci_pltfm_host *pltfm_host;
@@ -172,6 +173,12 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
goto clk_disable_all;
}
+ if (of_property_read_u32_array(pdev->dev.of_node,
+ "arasan,quirks", &quirktab[0], 2)) {
+ host->quirks |= quirktab[0];
+ host->quirks2 |= quirktab[1];
+ }
+
if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
--
2.3.7
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree
2015-07-27 8:04 [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree Shawn Lin
@ 2015-07-27 8:23 ` Michal Simek
2015-07-28 1:07 ` Shawn Lin
2015-07-27 15:19 ` Lars-Peter Clausen
1 sibling, 1 reply; 6+ messages in thread
From: Michal Simek @ 2015-07-27 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On 07/27/2015 10:04 AM, Shawn Lin wrote:
> This patch adds the interface to get quirks from dts, and
> there is no need to assign different quirks by condition statement
> of arasan IP version.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index ef5a7d2..db07788 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -132,6 +132,7 @@ static SIMPLE_DEV_PM_OPS(sdhci_arasan_dev_pm_ops, sdhci_arasan_suspend,
> static int sdhci_arasan_probe(struct platform_device *pdev)
> {
> int ret;
> + u32 quirktab[2];
> struct clk *clk_xin;
> struct sdhci_host *host;
> struct sdhci_pltfm_host *pltfm_host;
> @@ -172,6 +173,12 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> goto clk_disable_all;
> }
>
> + if (of_property_read_u32_array(pdev->dev.of_node,
> + "arasan,quirks", &quirktab[0], 2)) {
This is not documented anywhere that's why you should send binding to DT
mailing list and get ACK for it.
> + host->quirks |= quirktab[0];
> + host->quirks2 |= quirktab[1];
> + }
> +
> if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
> host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
> host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
>
Also is there any binding which is done in this way?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150727/777dda76/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree
2015-07-27 8:23 ` Michal Simek
@ 2015-07-28 1:07 ` Shawn Lin
2015-07-28 5:46 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Lin @ 2015-07-28 1:07 UTC (permalink / raw)
To: linux-arm-kernel
On 2015/7/27 16:23, Michal Simek wrote:
> On 07/27/2015 10:04 AM, Shawn Lin wrote:
>> This patch adds the interface to get quirks from dts, and
>> there is no need to assign different quirks by condition statement
>> of arasan IP version.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>> drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index ef5a7d2..db07788 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -132,6 +132,7 @@ static SIMPLE_DEV_PM_OPS(sdhci_arasan_dev_pm_ops, sdhci_arasan_suspend,
>> static int sdhci_arasan_probe(struct platform_device *pdev)
>> {
>> int ret;
>> + u32 quirktab[2];
>> struct clk *clk_xin;
>> struct sdhci_host *host;
>> struct sdhci_pltfm_host *pltfm_host;
>> @@ -172,6 +173,12 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>> goto clk_disable_all;
>> }
>>
>> + if (of_property_read_u32_array(pdev->dev.of_node,
>> + "arasan,quirks", &quirktab[0], 2)) {
> This is not documented anywhere that's why you should send binding to DT
> mailing list and get ACK for it.
Thanks, Michal. You'r right, and forgive me, a green hand, for my
inappropriate patch.
>> + host->quirks |= quirktab[0];
>> + host->quirks2 |= quirktab[1];
>> + }
>> +
>> if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>> host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>> host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
>>
> Also is there any binding which is done in this way?
Thanks.
BTW:
I got a FPGA board w/ a sdhci-arasn emmc controller & PHY IP which can
support emmc version 5.1.
But I cannot find any documented details from IP databook for the
vendor version, such as "sdhci-4.9a".
The only one is "ACS eMMC5.1 PHY IP uses TSMC ESD I/O protection
structures TMSC product name
tphn28hpcgv2od3 Version 120a". Is "sdhci-120a" the version if I add a
compatib node?
Kindly hope you can elaborate more ?)
> Thanks,
> Michal
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree
2015-07-28 1:07 ` Shawn Lin
@ 2015-07-28 5:46 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2015-07-28 5:46 UTC (permalink / raw)
To: linux-arm-kernel
On 07/28/2015 03:07 AM, Shawn Lin wrote:
> On 2015/7/27 16:23, Michal Simek wrote:
>> On 07/27/2015 10:04 AM, Shawn Lin wrote:
>>> This patch adds the interface to get quirks from dts, and
>>> there is no need to assign different quirks by condition statement
>>> of arasan IP version.
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>> ---
>>>
>>> drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c
>>> b/drivers/mmc/host/sdhci-of-arasan.c
>>> index ef5a7d2..db07788 100644
>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>> @@ -132,6 +132,7 @@ static SIMPLE_DEV_PM_OPS(sdhci_arasan_dev_pm_ops,
>>> sdhci_arasan_suspend,
>>> static int sdhci_arasan_probe(struct platform_device *pdev)
>>> {
>>> int ret;
>>> + u32 quirktab[2];
>>> struct clk *clk_xin;
>>> struct sdhci_host *host;
>>> struct sdhci_pltfm_host *pltfm_host;
>>> @@ -172,6 +173,12 @@ static int sdhci_arasan_probe(struct
>>> platform_device *pdev)
>>> goto clk_disable_all;
>>> }
>>> + if (of_property_read_u32_array(pdev->dev.of_node,
>>> + "arasan,quirks", &quirktab[0], 2)) {
>> This is not documented anywhere that's why you should send binding to DT
>> mailing list and get ACK for it.
> Thanks, Michal. You'r right, and forgive me, a green hand, for my
> inappropriate patch.
>>> + host->quirks |= quirktab[0];
>>> + host->quirks2 |= quirktab[1];
>>> + }
>>> +
>>> if (of_device_is_compatible(pdev->dev.of_node,
>>> "arasan,sdhci-4.9a")) {
>>> host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>>> host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
>>>
>> Also is there any binding which is done in this way?
> Thanks.
> BTW:
> I got a FPGA board w/ a sdhci-arasn emmc controller & PHY IP which can
> support emmc version 5.1.
> But I cannot find any documented details from IP databook for the
> vendor version, such as "sdhci-4.9a".
> The only one is "ACS eMMC5.1 PHY IP uses TSMC ESD I/O protection
> structures TMSC product name
> tphn28hpcgv2od3 Version 120a". Is "sdhci-120a" the version if I add a
> compatib node?
> Kindly hope you can elaborate more ?)
Is this xilinx board? If you look at TRM we have 8.9a arasan IP on Zynq
that's why we are using this compatible string. If you have different IP
version on your board feel free to extend compatible list and add
specific features for this IP.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150728/9f570e59/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree
2015-07-27 8:04 [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree Shawn Lin
2015-07-27 8:23 ` Michal Simek
@ 2015-07-27 15:19 ` Lars-Peter Clausen
2015-07-28 0:51 ` Shawn Lin
1 sibling, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2015-07-27 15:19 UTC (permalink / raw)
To: linux-arm-kernel
On 07/27/2015 10:04 AM, Shawn Lin wrote:
> This patch adds the interface to get quirks from dts, and
> there is no need to assign different quirks by condition statement
> of arasan IP version.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index ef5a7d2..db07788 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -132,6 +132,7 @@ static SIMPLE_DEV_PM_OPS(sdhci_arasan_dev_pm_ops, sdhci_arasan_suspend,
> static int sdhci_arasan_probe(struct platform_device *pdev)
> {
> int ret;
> + u32 quirktab[2];
> struct clk *clk_xin;
> struct sdhci_host *host;
> struct sdhci_pltfm_host *pltfm_host;
> @@ -172,6 +173,12 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> goto clk_disable_all;
> }
>
> + if (of_property_read_u32_array(pdev->dev.of_node,
> + "arasan,quirks", &quirktab[0], 2)) {
> + host->quirks |= quirktab[0];
> + host->quirks2 |= quirktab[1];
> + }
The quirks are part of the Linux internal API, making them part of the
public ABI is not necessarily the best idea. It means they become fixed, you
can't remove any quirk types, can't change any quirk type, nor can add new
quirk types.
- Lars
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree
2015-07-27 15:19 ` Lars-Peter Clausen
@ 2015-07-28 0:51 ` Shawn Lin
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Lin @ 2015-07-28 0:51 UTC (permalink / raw)
To: linux-arm-kernel
On 2015/7/27 23:19, Lars-Peter Clausen wrote:
> On 07/27/2015 10:04 AM, Shawn Lin wrote:
>> This patch adds the interface to get quirks from dts, and
>> there is no need to assign different quirks by condition statement
>> of arasan IP version.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>> drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c
>> b/drivers/mmc/host/sdhci-of-arasan.c
>> index ef5a7d2..db07788 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -132,6 +132,7 @@ static SIMPLE_DEV_PM_OPS(sdhci_arasan_dev_pm_ops,
>> sdhci_arasan_suspend,
>> static int sdhci_arasan_probe(struct platform_device *pdev)
>> {
>> int ret;
>> + u32 quirktab[2];
>> struct clk *clk_xin;
>> struct sdhci_host *host;
>> struct sdhci_pltfm_host *pltfm_host;
>> @@ -172,6 +173,12 @@ static int sdhci_arasan_probe(struct
>> platform_device *pdev)
>> goto clk_disable_all;
>> }
>>
>> + if (of_property_read_u32_array(pdev->dev.of_node,
>> + "arasan,quirks", &quirktab[0], 2)) {
>> + host->quirks |= quirktab[0];
>> + host->quirks2 |= quirktab[1];
>> + }
>
> The quirks are part of the Linux internal API, making them part of the
> public ABI is not necessarily the best idea. It means they become
> fixed, you can't remove any quirk types, can't change any quirk type,
> nor can add new quirk types.
>
Thank for your kindly reply, Lars. It seems I have lots to learn if I
want to get involved in upstream :)
So this patch is inappropriate for kernel.
> - Lars
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-28 5:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-27 8:04 [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree Shawn Lin
2015-07-27 8:23 ` Michal Simek
2015-07-28 1:07 ` Shawn Lin
2015-07-28 5:46 ` Michal Simek
2015-07-27 15:19 ` Lars-Peter Clausen
2015-07-28 0:51 ` Shawn Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).