linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: patrice.chotard@st.com (Patrice Chotard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] usb: host: ehci-st: Simplify return statement
Date: Tue, 4 Aug 2015 14:23:44 +0200	[thread overview]
Message-ID: <55C0AED0.7080303@st.com> (raw)
In-Reply-To: <29a173be5ace786d064ae14c02324fee42fee06c.1438678566.git.skarajga@visteon.com>

Hi

On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote:
> From: Saurabh Karajgaonkar <skarajga@visteon.com>
>
> Replace redundant variable use in return statement.
>
> Signed-off-by: Saurabh Karajgaonkar <skarajga@visteon.com>
> ---
>   drivers/usb/host/ehci-st.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
> index 7e4bd39..b7c5cfa 100644
> --- a/drivers/usb/host/ehci-st.c
> +++ b/drivers/usb/host/ehci-st.c
> @@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
>   	struct platform_device *pdev = to_platform_device(hcd->self.controller);
>   	struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev);
>   	struct ehci_hcd *ehci = hcd_to_ehci(hcd);
> -	int retval;
>   	u32 threshold;
>   
>   	/* Set EHCI packet buffer IN/OUT threshold to 128 bytes */
> @@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
>   	writel(threshold, hcd->regs + AHB2STBUS_INSREG01);
>   
>   	ehci->caps = hcd->regs + pdata->caps_offset;
> -	retval = ehci_setup(hcd);
> -	if (retval)
> -		return retval;
> -
> -	return 0;
> +	return ehci_setup(hcd);
>   }
>   
>   static int st_ehci_platform_power_on(struct platform_device *dev)


Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

Patrice

  reply	other threads:[~2015-08-04 12:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  9:07 [PATCH 0/9] usb: Simplify return statements Karajgaonkar, Saurabh (S.)
2015-08-04  9:08 ` [PATCH 1/9] usb: phy: phy-mxs-usb: Simplify return statement Karajgaonkar, Saurabh (S.)
2015-08-04  9:09 ` [PATCH 2/9] usb: phy: phy-keystone: " Karajgaonkar, Saurabh (S.)
2015-08-04  9:09 ` [PATCH 3/9] usb: musb: musb_dsps: " Karajgaonkar, Saurabh (S.)
2015-08-04  9:10 ` [PATCH 4/9] usb: host: ehci-st: " Karajgaonkar, Saurabh (S.)
2015-08-04 12:23   ` Patrice Chotard [this message]
2015-08-04  9:10 ` [PATCH 5/9] usb: host: oxu210hp-hcd: " Karajgaonkar, Saurabh (S.)
2015-08-04  9:11 ` [PATCH 6/9] usb: host: u132-hcd: " Karajgaonkar, Saurabh (S.)
2015-08-04  9:11 ` [PATCH 7/9] usb: host: xhci: " Karajgaonkar, Saurabh (S.)
2015-08-04  9:11 ` [PATCH 8/9] usb: serial: mxuport: " Karajgaonkar, Saurabh (S.)
2015-08-04  9:12 ` [PATCH 9/9] usb: misc: ftdi-elan: " Karajgaonkar, Saurabh (S.)
2015-08-04 10:03   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C0AED0.7080303@st.com \
    --to=patrice.chotard@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).