From mboxrd@z Thu Jan 1 00:00:00 1970 From: patrice.chotard@st.com (Patrice Chotard) Date: Tue, 4 Aug 2015 14:23:44 +0200 Subject: [PATCH 4/9] usb: host: ehci-st: Simplify return statement In-Reply-To: <29a173be5ace786d064ae14c02324fee42fee06c.1438678566.git.skarajga@visteon.com> References: <29a173be5ace786d064ae14c02324fee42fee06c.1438678566.git.skarajga@visteon.com> Message-ID: <55C0AED0.7080303@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote: > From: Saurabh Karajgaonkar > > Replace redundant variable use in return statement. > > Signed-off-by: Saurabh Karajgaonkar > --- > drivers/usb/host/ehci-st.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c > index 7e4bd39..b7c5cfa 100644 > --- a/drivers/usb/host/ehci-st.c > +++ b/drivers/usb/host/ehci-st.c > @@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd) > struct platform_device *pdev = to_platform_device(hcd->self.controller); > struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev); > struct ehci_hcd *ehci = hcd_to_ehci(hcd); > - int retval; > u32 threshold; > > /* Set EHCI packet buffer IN/OUT threshold to 128 bytes */ > @@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd) > writel(threshold, hcd->regs + AHB2STBUS_INSREG01); > > ehci->caps = hcd->regs + pdata->caps_offset; > - retval = ehci_setup(hcd); > - if (retval) > - return retval; > - > - return 0; > + return ehci_setup(hcd); > } > > static int st_ehci_platform_power_on(struct platform_device *dev) Acked-by: Patrice Chotard Thanks Patrice