From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: irqdomain_hierarchy: fix arm gic irq type configuration
Date: Tue, 11 Aug 2015 15:16:13 +0300 [thread overview]
Message-ID: <55C9E78D.7040404@ti.com> (raw)
In-Reply-To: <20150811122456.1efe1656@arm.com>
On 08/11/2015 02:24 PM, Marc Zyngier wrote:
> On Tue, 11 Aug 2015 10:25:47 +0100
> Grygorii Strashko <grygorii.strashko@ti.com> wrote:
>
> Hi Grygorii,
>
>> It's observed that ARM GIC IRQ triggering type is not configured
>> properly when IRQ is routed through IRQ domains hierarchy and
>> system started using DT. As result, system will start using default
>> ARM GIC configuration, ignore DT IRQ type configuration,
>> and value of desc->irq_data.state_use_accessors = 0.
>>
>> In case of TI OMAP the following IRQ hierarchy is defined:
>> ARM GIC <- OMAP wakeupgen <- TI CBAR
>>
>> Failed call chain:
>> irq_create_of_mapping
>> irq_set_irq_type
>> __irq_set_trigger
>> if (!chip || !chip->irq_set_type) {
>> return 0; <- return here
>> }
>> CBAR has no .irq_set_type() defined and, so, IRQ triggering
>> configuration will not be propagated to parent IRQ domain.
>>
>> Hence, fix it by introducing irq_chip_set_type_parent(), in the
>> same manner as irq_chip_set_wake_parent(), and use it for IRQ
>> triggering type propagation to the parent IRQ domain in
>> irq-crossbar and omap-wakeupgen.
>>
>> / # cat /proc/interrupts -- before
>> 230: 0 0 CBAR 30 Edge -00000000 48051000.gpio
>> 263: 0 0 CBAR 116 Edge -00000000 48053000.gpio
>> 296: 246 0 CBAR 67 Edge -00000000 OMAP UART0
>> 311: 341 0 CBAR 51 Edge -00000000 48070000.i2c
>> 312: 3 0 CBAR 52 Edge -00000000 48072000.i2c
>> 313: 0 0 CBAR 56 Edge -00000000 48060000.i2c
>> 314: 255 0 CBAR 78 Edge -00000000 mmc0
>> 315: 40 0 CBAR 81 Edge -00000000 mmc1
>> 316: 13 0 CBAR 91 Edge -00000000 mmc2
>> 320: 0 0 CBAR 49 Edge -00000000 4a140000.sata
>> 324: 0 0 CBAR 1 Edge -00000000 48078000.elm
>> 325: 0 0 CBAR 15 Edge -00000000 gpmc
>> 333: 0 0 CBAR 335 Edge -00000000 48484000.ethernet
>> 334: 0 0 CBAR 336 Edge -00000000 48484000.ethernet
>> 415: 0 0 pcf857x 2 Edge -00000000 btnUser1
>> 416: 0 0 pcf857x 3 Edge -00000000 btnUser2
>> 445: 0 0 pinctrl 992 Edge -00010000 4806a000.seria
>>
>> / # cat /proc/interrupts -- after
>> 230: 0 0 CBAR 30 Level -00002004 48051000.gpio
>> 263: 0 0 CBAR 116 Level -00002004 48053000.gpio
>> 296: 567 0 CBAR 67 Level -00002004 OMAP UART0
>> 311: 363 0 CBAR 51 Level -00002004 48070000.i2c
>> 312: 3 0 CBAR 52 Level -00002004 48072000.i2c
>> 313: 0 0 CBAR 56 Level -00002004 48060000.i2c
>> 314: 197 0 CBAR 78 Level -00002004 mmc0
>> 315: 40 0 CBAR 81 Level -00002004 mmc1
>> 316: 13 0 CBAR 91 Level -00002004 mmc2
>> 320: 0 0 CBAR 49 Level -00002004 4a140000.sata
>> 324: 0 0 CBAR 1 Level -00002004 48078000.elm
>> 325: 0 0 CBAR 15 Level -00002004 gpmc
>> 333: 0 0 CBAR 335 Level -00002004 48484000.ethernet
>> 334: 0 0 CBAR 336 Level -00002004 48484000.ethernet
>> 415: 0 0 pcf857x 2 Edge -00000000 btnUser1
>> 416: 4 2 pcf857x 3 Edge -00000000 btnUser2
>> 445: 0 0 pinctrl 992 Edge -00010000 4806a000.serial
>>
>> Fixes: 783d31863fb8 ('irqchip: crossbar: Convert dra7 crossbar to stacked domains')
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> Hi All,
>>
>> I can split patch if required and overall solution acceptable.
>
> This looks good to me. Please repost it after splitting it in two
> patches.
just to clarify - Do you want to see two or three patches?
2) or 3) arch/arm/mach-omap2/omap-wakeupgen.c | 1 +
2) drivers/irqchip/irq-crossbar.c | 1 +
1) include/linux/irq.h | 1 +
1) kernel/irq/chip.c | 16 ++++++++++++++++
--
regards,
-grygorii
next prev parent reply other threads:[~2015-08-11 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 9:25 [PATCH] ARM: OMAP: irqdomain_hierarchy: fix arm gic irq type configuration Grygorii Strashko
2015-08-11 11:24 ` Marc Zyngier
2015-08-11 12:16 ` Grygorii Strashko [this message]
2015-08-11 14:33 ` Marc Zyngier
2015-08-12 17:48 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C9E78D.7040404@ti.com \
--to=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).