From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support
Date: Wed, 12 Aug 2015 12:41:31 +0100 [thread overview]
Message-ID: <55CB30EB.3050006@linaro.org> (raw)
In-Reply-To: <20150812113203.GA15470@Sanchayan-Arch.toradex.int>
On 12/08/15 12:32, maitysanchayan at gmail.com wrote:
> Hello,
>
> On 15-08-12 11:41:55, Srinivas Kandagatla wrote:
>> >Hi Sanchayan,
>> >
>> >Please run checkpatch before you send the patch next time.
>> >Look at Documentation/SubmittingPatches for more details.
>> >
>> >WARNING: line over 80 characters
>> >#225: FILE: drivers/nvmem/vf610-ocotp.c:174:
>> >+ ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG);
>> >
>> >WARNING: line over 80 characters
>> >#237: FILE: drivers/nvmem/vf610-ocotp.c:186:
>> >+ ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG);
>> >
>> >WARNING: line over 80 characters
>> >#244: FILE: drivers/nvmem/vf610-ocotp.c:193:
>> >+ writel(OCOTP_CTRL_ERROR, ocotp->base + OCOTP_CTRL_CLR);
>> >
> I had. However splitting these lines seemed odd. Will split and fix.
>
Just get the base to a local variable, which should make it look neat
and this will avoid de-referencing the octop in the all the time in loop.
--srini
next prev parent reply other threads:[~2015-08-12 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 14:11 [PATCH v8 0/4] Implement OCOTP driver for Vybrid using NVMEM Sanchayan Maity
2015-08-10 14:11 ` [PATCH v8 1/4] clk: clk-vf610: Add clock for Vybrid OCOTP controller Sanchayan Maity
2015-08-10 14:11 ` [PATCH v8 2/4] ARM: dts: vfxxx: Add OCOTP node Sanchayan Maity
2015-08-10 14:11 ` [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support Sanchayan Maity
2015-08-10 14:56 ` Srinivas Kandagatla
2015-08-12 10:41 ` Srinivas Kandagatla
2015-08-12 11:32 ` maitysanchayan at gmail.com
2015-08-12 11:41 ` Srinivas Kandagatla [this message]
2015-08-10 14:11 ` [PATCH v8 4/4] nvmem: Add DT binding documentation for Vybrid OCOTP driver Sanchayan Maity
2015-08-10 14:57 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB30EB.3050006@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).