From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH v2] pinctrl: sun4i: add spdif to pin description.
Date: Thu, 13 Aug 2015 10:58:44 +0200 [thread overview]
Message-ID: <55CC5C44.5060507@redhat.com> (raw)
In-Reply-To: <1439400468-1563-2-git-send-email-codekipper@gmail.com>
Hi,
On 12-08-15 19:27, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
LGTM:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c
> index 7376a97..862a096 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c
> @@ -135,7 +135,14 @@ static const struct sunxi_desc_pin sun4i_a10_pins[] = {
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 3),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> - SUNXI_FUNCTION(0x2, "ir0")), /* TX */
> + SUNXI_FUNCTION(0x2, "ir0"), /* TX */
> + /*
> + * The SPDIF block is not referenced at all in the A10 user
> + * manual. However it is described in the code leaked and the
> + * pin descriptions are declared in the A20 user manual which
> + * is pin compatible with this device.
> + */
> + SUNXI_FUNCTION(0x4, "spdif")), /* SPDIF MCLK */
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 4),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> @@ -176,11 +183,15 @@ static const struct sunxi_desc_pin sun4i_a10_pins[] = {
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> SUNXI_FUNCTION(0x2, "i2s"), /* DI */
> - SUNXI_FUNCTION(0x3, "ac97")), /* DI */
> + SUNXI_FUNCTION(0x3, "ac97"), /* DI */
> + /* Undocumented mux function - See SPDIF MCLK above */
> + SUNXI_FUNCTION(0x4, "spdif")), /* SPDIF IN */
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 13),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> - SUNXI_FUNCTION(0x2, "spi2")), /* CS1 */
> + SUNXI_FUNCTION(0x2, "spi2"), /* CS1 */
> + /* Undocumented mux function - See SPDIF MCLK above */
> + SUNXI_FUNCTION(0x4, "spdif")), /* SPDIF OUT */
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 14),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
>
next prev parent reply other threads:[~2015-08-13 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 17:27 [PATCH v2] pinctrl: sun4i: add spdif to pin description codekipper at gmail.com
2015-08-12 17:27 ` codekipper at gmail.com
2015-08-13 8:58 ` Hans de Goede [this message]
2015-08-13 14:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC5C44.5060507@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).