linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: guohanjun@huawei.com (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] Display a DMA error message
Date: Thu, 13 Aug 2015 19:02:17 +0800	[thread overview]
Message-ID: <55CC7939.7020800@huawei.com> (raw)
In-Reply-To: <1439416290-21228-3-git-send-email-jeremy.linton@arm.com>

On 2015/8/13 5:51, Jeremy Linton wrote:
> If the ehci driver fails to configure the dma settings then display
> a dev error instead of simply failing. This is triggered in an
> ACPI world if the user fails to set the _CCA on the device.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  drivers/usb/host/ehci-platform.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
> index 2593def..82e396f 100644
> --- a/drivers/usb/host/ehci-platform.c
> +++ b/drivers/usb/host/ehci-platform.c
> @@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev)
>  
>  	err = dma_coerce_mask_and_coherent(&dev->dev,
>  		pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
> -	if (err)
> +	if (err) {
> +		dev_err(&dev->dev, "Error: DMA setup failed\n");
>  		return err;
> +	}
>  
>  	irq = platform_get_irq(dev, 0);
>  	if (irq < 0) {

Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>

Thanks
Hanjun

  reply	other threads:[~2015-08-13 11:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 21:51 [PATCH 0/3] Enable EHCI-platform driver for use with ACPI Jeremy Linton
2015-08-12 21:51 ` [PATCH 1/3] Honor ACPI _CCA attribute setting Jeremy Linton
2015-08-14  1:45   ` Suravee Suthikulpanit
2015-08-14 13:14     ` Catalin Marinas
2015-08-14 14:12     ` Jeremy Linton
2015-08-18  3:36       ` Huang Shijie
2015-08-12 21:51 ` [PATCH 2/3] Display a DMA error message Jeremy Linton
2015-08-13 11:02   ` Hanjun Guo [this message]
2015-08-13 14:52   ` Alan Stern
2015-08-14 21:19   ` Arnd Bergmann
2015-08-14 21:44     ` Jeremy Linton
2015-08-14 21:56       ` Arnd Bergmann
2015-08-12 21:51 ` [PATCH 3/3] Add ACPI bindings for the EHCI platform driver Jeremy Linton
2015-08-13 11:50   ` Hanjun Guo
2015-08-13 14:45     ` Jeremy Linton
2015-08-13 14:53   ` Alan Stern
2015-08-13 15:13     ` Jeremy Linton
2015-08-18  3:35       ` Huang Shijie
2015-08-13  9:44 ` [PATCH 0/3] Enable EHCI-platform driver for use with ACPI Graeme Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CC7939.7020800@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).