linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] serial: xuartps: Do not handle overrun errors under IGNPAR option
Date: Mon, 17 Aug 2015 11:49:43 -0400	[thread overview]
Message-ID: <55D20297.6010500@hurleysoftware.com> (raw)
In-Reply-To: <41df6eb35d69801afa5b686a6974e3c3bf65178a.1439796149.git.michal.simek@xilinx.com>

On 08/17/2015 03:22 AM, Michal Simek wrote:
> From: Anirudha Sarangi <anirudha.sarangi@xilinx.com>
> 
> The existing implementation includes overrun errors under IGNPAR
> option. This patch fixes it by including only parity and framing
> error under IGNPAR option.

The convention adopted by Linux serial drivers is to ignore overrun
errors if both IGNPAR and IGNBRK are set.

Regards,
Peter Hurley

> Signed-off-by: Anirudha Sarangi <anirudh@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/tty/serial/xilinx_uartps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index a3020344ac9d..c4437e8929ff 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -691,7 +691,7 @@ static void cdns_uart_set_termios(struct uart_port *port,
>  
>  	if (termios->c_iflag & IGNPAR)
>  		port->ignore_status_mask |= CDNS_UART_IXR_PARITY |
> -			CDNS_UART_IXR_FRAMING | CDNS_UART_IXR_OVERRUN;
> +					    CDNS_UART_IXR_FRAMING;
>  
>  	/* ignore all characters if CREAD is not set */
>  	if ((termios->c_cflag & CREAD) == 0)
> 

  reply	other threads:[~2015-08-17 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17  7:22 [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity Michal Simek
2015-08-17  7:22 ` [PATCH 2/4] serial: xuartps: Do not handle overrun errors under IGNPAR option Michal Simek
2015-08-17 15:49   ` Peter Hurley [this message]
2015-08-17 15:58     ` Anirudha Sarangi
2015-08-17 16:19       ` Peter Hurley
2015-08-17 18:07         ` Anirudha Sarangi
2015-08-17  7:22 ` [PATCH 3/4] serial: xuartps: Do not enable parity error interrupt Michal Simek
2015-08-17  7:22 ` [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic Michal Simek
2015-08-17 15:55   ` Peter Hurley
2015-08-17 16:00     ` Anirudha Sarangi
2015-08-17 18:46       ` Peter Hurley
2015-08-17 15:39 ` [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity Peter Hurley
2015-08-17 15:55   ` Anirudha Sarangi
2015-08-17 16:24     ` Peter Hurley
2015-08-17 18:06       ` Anirudha Sarangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D20297.6010500@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).