From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue
Date: Tue, 25 Aug 2015 14:11:53 +0530 [thread overview]
Message-ID: <55DC2A51.6090008@linaro.org> (raw)
In-Reply-To: <20150825075121.GE19409@x1>
On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote:
> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>
>> Driver had coding style issues where spaces were used instead
>> of tabs. This patch fixes them all.
>
> That's not all it's doing though is it?
>
Yes, its just tabbing related fixes.
> Please describe all of your changes.
>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>> drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++--------------------------
>> 1 file changed, 61 insertions(+), 64 deletions(-)
>>
>> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
>> index f104a32..c4e097d 100644
>> --- a/drivers/mfd/88pm800.c
>> +++ b/drivers/mfd/88pm800.c
>> @@ -30,55 +30,55 @@
>> #include <linux/of_device.h>
>>
>> /* Interrupt Registers */
>> -#define PM800_INT_STATUS1 (0x05)
>> +#define PM800_INT_STATUS1 0x05
>> #define PM800_ONKEY_INT_STS1 (1 << 0)
>> #define PM800_EXTON_INT_STS1 (1 << 1)
>> -#define PM800_CHG_INT_STS1 (1 << 2)
>> -#define PM800_BAT_INT_STS1 (1 << 3)
>> -#define PM800_RTC_INT_STS1 (1 << 4)
>> +#define PM800_CHG_INT_STS1 (1 << 2)
>> +#define PM800_BAT_INT_STS1 (1 << 3)
>> +#define PM800_RTC_INT_STS1 (1 << 4)
>> #define PM800_CLASSD_OC_INT_STS1 (1 << 5)
>
> These should all be replaced by BIT().
>
> Please fix the whole file.
Will do.
Thanks,
Vaibhav
next prev parent reply other threads:[~2015-08-25 8:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 18:56 [PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath
2015-08-25 7:51 ` Lee Jones
2015-08-25 8:41 ` Vaibhav Hiremath [this message]
2015-08-25 10:30 ` Lee Jones
2015-08-25 10:49 ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 7:52 ` Lee Jones
2015-08-25 8:50 ` Vaibhav Hiremath
2015-08-25 10:35 ` Lee Jones
2015-08-25 10:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros Vaibhav Hiremath
2015-08-25 7:55 ` Lee Jones
2015-08-25 8:45 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information Vaibhav Hiremath
2015-08-25 7:58 ` Lee Jones
2015-08-25 8:51 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 4/5] clk: 88pm800: Add clk provider driver for 88pm800 family of devices Vaibhav Hiremath
2015-08-25 5:08 ` Krzysztof Kozlowski
2015-08-24 18:56 ` [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice Vaibhav Hiremath
2015-08-25 5:25 ` Krzysztof Kozlowski
2015-08-25 7:49 ` Lee Jones
2015-08-25 8:38 ` Vaibhav Hiremath
2015-08-25 8:31 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC2A51.6090008@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).