From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: ti: reset irq affinity before freeing irq
Date: Thu, 27 Aug 2015 11:43:43 -0500 [thread overview]
Message-ID: <55DF3E3F.6030506@mentor.com> (raw)
In-Reply-To: <1440690671-1029-1-git-send-email-m-karicheri2@ti.com>
On 08/27/2015 10:51 AM, Murali Karicheri wrote:
> When using accumulator queue for rx side for network driver, following
> warning is seen when doing a reboot command from Linux console. This
> is because, affinity value is not reset before calling free_irq(). This
> patch fixes this.
>
> Deconfiguring network interfaces...
> [ 55.176589] ------------[ cut here ]-----------
> [ 55.181232] WARNING: CPU: 0 PID: 2081 at kernel/irq/manage.c:1370
> __free_irq+0x208/0x214
The full content of the warning should be included in the commit
message; __free_irq has several potential sources of warning messages,
and line 1370 doesn't correspond to any of them in 4.2-rc8.
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
> - Applies to v4.2.0-rc8
>
> drivers/soc/ti/knav_qmss_acc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c
> index ef6f69d..b98fe56 100644
> --- a/drivers/soc/ti/knav_qmss_acc.c
> +++ b/drivers/soc/ti/knav_qmss_acc.c
> @@ -261,6 +261,10 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
> if (old && !new) {
> dev_dbg(kdev->dev, "setup-acc-irq: freeing %s for channel %s\n",
> acc->name, acc->name);
> + ret = irq_set_affinity_hint(irq, NULL);
> + if (ret)
> + dev_warn(range->kdev->dev,
> + "Failed to set IRQ affinity\n");
Seems unnecessary to add a warning here.
next prev parent reply other threads:[~2015-08-27 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:51 [PATCH] soc: ti: reset irq affinity before freeing irq Murali Karicheri
2015-08-27 16:39 ` santosh.shilimkar at oracle.com
2015-08-27 16:43 ` Nathan Lynch [this message]
2015-08-27 18:23 ` Murali Karicheri
2015-08-27 18:34 ` Nathan Lynch
2015-08-27 18:36 ` santosh.shilimkar at oracle.com
2015-08-27 21:43 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DF3E3F.6030506@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).