From: tomasz.nowicki@linaro.org (Tomasz Nowicki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/11] x86, pci: Clean up comment about buggy MMIO config space access for AMD Fam10h CPUs.
Date: Mon, 31 Aug 2015 14:04:23 +0200 [thread overview]
Message-ID: <55E442C7.7060509@linaro.org> (raw)
In-Reply-To: <1432644564-24746-3-git-send-email-hanjun.guo@linaro.org>
On 26.05.2015 14:49, Hanjun Guo wrote:
> From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>
> - fix typo
> - improve explanation
> - add reference to the related document
>
> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> ---
> arch/x86/include/asm/pci_x86.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h
> index 164e3f8..eddf8f0 100644
> --- a/arch/x86/include/asm/pci_x86.h
> +++ b/arch/x86/include/asm/pci_x86.h
> @@ -154,10 +154,13 @@ extern struct list_head pci_mmcfg_list;
>
> /*
> * AMD Fam10h CPUs are buggy, and cannot access MMIO config space
> - * on their northbrige except through the * %eax register. As such, you MUST
> - * NOT use normal IOMEM accesses, you need to only use the magic mmio-config
> + * on their northbridge except through the * %eax register. As such, you MUST
> + * NOT use normal IOMEM accesses, you need to only use the magic mmio_config_*
> * accessor functions.
> - * In fact just use pci_config_*, nothing else please.
> + *
> + * Please refer to the following doc:
> + * "BIOS and Kernel Developer's Guide (BKDG) For AMD Family 10h Processors",
> + * rev. 3.48, sec 2.11.1, "MMIO Configuration Coding Requirements".
> */
> static inline unsigned char mmio_config_readb(void __iomem *pos)
> {
>
Hi Bjorn,
Can you please consider to pick up this one patch?
Regards,
Tomasz
next prev parent reply other threads:[~2015-08-31 12:04 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 12:49 [PATCH 00/11] ARM64 PCI hostbridge init based on ACPI Hanjun Guo
2015-05-26 12:49 ` [PATCH 01/11] ARM64 / PCI: introduce struct pci_controller for ACPI Hanjun Guo
2015-05-26 16:58 ` Liviu Dudau
2015-05-26 17:20 ` Jiang Liu
2015-05-27 8:21 ` Hanjun Guo
2015-09-07 4:14 ` Ganapatrao Kulkarni
2015-09-07 8:45 ` Lorenzo Pieralisi
2015-09-08 13:35 ` Hanjun Guo
2015-05-27 9:47 ` Liviu Dudau
2015-05-27 11:29 ` Jiang Liu
2015-05-26 12:49 ` [PATCH 02/11] x86, pci: Clean up comment about buggy MMIO config space access for AMD Fam10h CPUs Hanjun Guo
2015-08-31 12:04 ` Tomasz Nowicki [this message]
2015-05-26 12:49 ` [PATCH 03/11] x86, pci: Abstract PCI config accessors and use AMD Fam10h workaround exclusively Hanjun Guo
2015-05-26 12:49 ` [PATCH 04/11] x86, pci: Reorder logic of pci_mmconfig_insert() function Hanjun Guo
2015-05-26 12:49 ` [PATCH 05/11] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Hanjun Guo
2015-05-26 17:08 ` Will Deacon
2015-05-27 8:06 ` Tomasz Nowicki
2015-06-02 13:32 ` Lorenzo Pieralisi
2015-06-04 9:28 ` Hanjun Guo
2015-06-04 10:22 ` Lorenzo Pieralisi
2015-06-04 12:28 ` Hanjun Guo
2015-06-08 2:57 ` Hanjun Guo
2015-06-08 15:14 ` Lorenzo Pieralisi
2015-08-31 11:01 ` Tomasz Nowicki
2015-09-07 9:59 ` Tomasz Nowicki
2015-09-08 15:07 ` Lorenzo Pieralisi
2015-09-09 13:47 ` Tomasz Nowicki
2015-09-11 11:20 ` Lorenzo Pieralisi
2015-09-11 12:35 ` Tomasz Nowicki
2015-09-14 9:37 ` Lorenzo Pieralisi
2015-09-14 11:34 ` Tomasz Nowicki
2015-09-14 14:55 ` Tomasz Nowicki
2015-09-25 16:02 ` Tomasz Nowicki
2015-09-25 16:19 ` Lorenzo Pieralisi
2015-10-15 13:22 ` Lorenzo Pieralisi
2015-10-15 14:34 ` Tomasz Nowicki
2015-10-15 16:26 ` Marc Zyngier
2015-10-15 18:51 ` Tomasz Nowicki
2015-05-26 12:49 ` [PATCH 06/11] pci, acpi, mcfg: Provide generic implementation of MCFG code initialization Hanjun Guo
2015-05-26 12:49 ` [PATCH 07/11] x86, pci: mmconfig_{32, 64}.c code refactoring - remove code duplication Hanjun Guo
2015-05-26 12:49 ` [PATCH 08/11] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver Hanjun Guo
2015-05-26 12:49 ` [PATCH 09/11] pci, acpi, mcfg: Share ACPI PCI config space accessors Hanjun Guo
2015-05-26 12:49 ` [PATCH 10/11] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y Hanjun Guo
2015-05-26 13:54 ` Boris Ostrovsky
2015-05-26 14:00 ` Boris Ostrovsky
2015-05-26 14:54 ` Tomasz Nowicki
2015-05-26 15:44 ` Boris Ostrovsky
2015-05-27 3:55 ` Hanjun Guo
2015-05-26 12:49 ` [PATCH 11/11] ARM64 / PCI / ACPI: support for ACPI based PCI hostbridge init Hanjun Guo
2015-05-26 15:12 ` Tomasz Nowicki
2015-05-27 7:31 ` Hanjun Guo
2015-05-26 17:13 ` Will Deacon
2015-05-26 17:24 ` Jiang Liu
2015-05-27 0:30 ` [PATCH 00/11] ARM64 PCI hostbridge init based on ACPI Rafael J. Wysocki
2015-05-27 3:57 ` Hanjun Guo
2015-06-08 12:05 ` Jagan Teki
2015-06-10 2:47 ` Hanjun Guo
2015-10-15 19:15 ` Jon Masters
2015-10-15 23:42 ` Hanjun Guo
2015-10-15 23:49 ` Jon Masters
2015-12-07 20:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E442C7.7060509@linaro.org \
--to=tomasz.nowicki@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).