From: jarkko.nikula@linux.intel.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c
Date: Tue, 01 Sep 2015 09:36:04 +0300 [thread overview]
Message-ID: <55E54754.1060002@linux.intel.com> (raw)
In-Reply-To: <1441073073.12012.3.camel@ingics.com>
Hi
Adding linux-spi and Mark Brown.
On 09/01/2015 05:04 AM, Axel Lin wrote:
> CC [M] arch/arm/plat-pxa/ssp.o
> arch/arm/plat-pxa/ssp.c:110:52: error: 'LPSS_SSP' undeclared here (not in a function)
> scripts/Makefile.build:264: recipe for target 'arch/arm/plat-pxa/ssp.o' failed
> make[1]: *** [arch/arm/plat-pxa/ssp.o] Error 1
> Makefile:965: recipe for target 'arch/arm/plat-pxa' failed
> make: *** [arch/arm/plat-pxa] Error 2
>
>
> The build error is introduced by:
> commit 03fbf488cece461468d3abb795f5e5f055e00040
> Author: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Date: Thu Jun 4 16:55:10 2015 +0300
>
> spi: pxa2xx: Differentiate Intel LPSS types
>
I obviously didn't do tree wide grep for LPSS_SSP and pxa3xx_defconfig
don't reveal it without setting CONFIG_USE_OF. Sorry about that.
No I'm pondering how to fix this. I see these bindings are added by the
commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") but some of the
types are not used anywhere. For instance PXA168_SSP or PXA910_SSP. Then
PXA3xx_SSP is used in sound/soc/pxa/pxa-ssp.c and CE4100_SSP in
drivers/spi/spi-pxa2xx.c (where LPSS_SSP was used too before
differentiating it).
What I'm wondering is this binding below correct in
arch/arm/plat-pxa/ssp.c? LPSS_SSP was meant to be for Intel Intel Low
Power Subsystem SPI.
"{ .compatible = "mrvl,lpss-ssp", .data = (void *) LPSS_SSP }"
Mika, Daniel: do you know is there any change there is a Marvell PXA
platform compatible with Intel LPSS or is above binding bogus?
--
Jarkko
next prev parent reply other threads:[~2015-09-01 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 2:04 ARM: pxa: build error in arch/arm/plat-pxa/ssp.c Axel Lin
2015-09-01 6:36 ` Jarkko Nikula [this message]
2015-09-01 18:43 ` Mark Brown
2015-09-02 0:42 ` Axel Lin
2015-09-02 7:40 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E54754.1060002@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).