From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: mediatek: Consistently use the BIT() macro
Date: Tue, 1 Sep 2015 11:45:19 +0200 [thread overview]
Message-ID: <55E573AF.4060408@gmail.com> (raw)
In-Reply-To: <1440804302-6903-1-git-send-email-javier@osg.samsung.com>
On 29/08/15 01:25, Javier Martinez Canillas wrote:
> The mediatek pinctrl driver uses the BIT() macro instead of open
> coding 1 << n in all but one place. Replace this occurrence with
> the BIT() macro for consistency.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 23f2de07f598..497b9125342a 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -898,7 +898,7 @@ static int mtk_eint_flip_edge(struct mtk_pinctrl *pctl, int hwirq)
> int start_level, curr_level;
> unsigned int reg_offset;
> const struct mtk_eint_offsets *eint_offsets = &(pctl->devdata->eint_offsets);
> - u32 mask = 1 << (hwirq & 0x1f);
> + u32 mask = BIT(hwirq & 0x1f);
> u32 port = (hwirq >> 5) & eint_offsets->port_mask;
> void __iomem *reg = pctl->eint_reg_base + (port << 2);
> const struct mtk_desc_pin *pin;
>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
next prev parent reply other threads:[~2015-09-01 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 23:25 [PATCH] pinctrl: mediatek: Consistently use the BIT() macro Javier Martinez Canillas
2015-09-01 9:45 ` Matthias Brugger [this message]
2015-09-25 16:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E573AF.4060408@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).