From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
Date: Fri, 4 Sep 2015 02:26:28 +0200 [thread overview]
Message-ID: <55E8E534.1040204@osg.samsung.com> (raw)
In-Reply-To: <55E8DDDD.80106@samsung.com>
Hello Krzysztof,
On 09/04/2015 01:55 AM, Krzysztof Kozlowski wrote:
> On 04.09.2015 03:11, Anand Moon wrote:
>> Earlier design of the LED for Odroid XU3 was using gpio-leds
>> Now It was change to using both pwm-leds and gpio-leds.
>
> It is still not a reason for this change. gpio-leds were not enabled
> before. This could be a valid reason of adding LEDS_PWM to existing
> config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on
> the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?
>
Agreed, also the commit message doesn't explain why the heartbeat
LED trigger is enabled as I mentioned in the previous version.
> Actually I gave up on this and I wanted to change the commit message on
> myself when applying. But discussion was brought up again so... clearly
> we have different understanding of the meaning of "WHY". :)
>
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-09-04 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 18:11 [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon
2015-09-03 23:55 ` Krzysztof Kozlowski
2015-09-04 0:26 ` Javier Martinez Canillas [this message]
2015-09-04 2:49 ` Anand Moon
2015-09-04 6:20 ` Anand Moon
2015-09-04 6:48 ` Krzysztof Kozlowski
2015-09-04 6:54 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E8E534.1040204@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).