linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node
Date: Tue, 8 Sep 2015 18:46:14 -0500	[thread overview]
Message-ID: <55EF7346.5040607@kernel.org> (raw)
In-Reply-To: <CAAEAJfCg+O=b9pfndG2WfxKVk9gvcqHUL0MV4fDpHj_9CaCBbQ@mail.gmail.com>

On 09/08/2015 10:18 AM, Ezequiel Garcia wrote:
> On 8 September 2015 at 08:53, Jagan Teki <jteki@openedev.com> wrote:
>> On 8 September 2015 at 15:19, Bayi Cheng <bayi.cheng@mediatek.com> wrote:
>>> Add Mediatek nor flash node
>>>
>>> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
>>> ---
>>>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index d18ee42..a14f005 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -365,6 +365,16 @@
>>>                         status = "disabled";
>>>                 };
>>>
>>> +               nor_flash: nor at 1100d000 {
>>
>> Based on the comments from 1/3 - this notation needs to be change something like
>> qspi0: quadspi at 1100d000
>>
> 
> Actually, to follow ePAPR recomendations it should be named as flash at 1100d000.
> (See ePAPR, 2.2.2 Generic Names Recommendation).

The flash device node should, but this is the controller which should be
"spi" IMO even if this is not a general purpose controller.

Rob

  reply	other threads:[~2015-09-08 23:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08  9:49 [PATCH 0/3] Mediatek SPI-NOR flash driver Bayi Cheng
2015-09-08  9:49 ` [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Bayi Cheng
2015-09-08 11:34   ` Jagan Teki
2015-09-15  6:49     ` bayi.cheng
2015-09-09  5:47   ` Sascha Hauer
2015-09-15  6:39     ` bayi.cheng
2015-09-11 21:47   ` Brian Norris
2015-09-11 21:49   ` Brian Norris
2015-09-15  6:53     ` bayi.cheng
2015-09-08  9:49 ` [PATCH 2/3] mtd: mtk-nor: mtk serial flash controller driver Bayi Cheng
2015-09-09  6:37   ` Sascha Hauer
2015-09-09 13:00     ` Lothar Waßmann
2015-09-15 16:37       ` bayi.cheng
2015-09-15 16:23     ` bayi.cheng
2015-09-08  9:49 ` [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Bayi Cheng
2015-09-08 11:53   ` Jagan Teki
2015-09-08 15:18     ` Ezequiel Garcia
2015-09-08 23:46       ` Rob Herring [this message]
2015-09-11  9:51         ` bayi.cheng
2015-09-11 21:56           ` Brian Norris
2015-09-11  9:49       ` bayi.cheng
2015-09-11  9:47     ` bayi.cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EF7346.5040607@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).