public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: ariel@vanguardiasur.com.ar (Ariel D'Alessandro)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: domains: Possible regression in v7-M
Date: Wed, 9 Sep 2015 15:25:41 -0300	[thread overview]
Message-ID: <55F079A5.1010501@vanguardiasur.com.ar> (raw)
In-Reply-To: <20150909175230.GF21084@n2100.arm.linux.org.uk>

Russell,

El 09/09/15 a las 14:52, Russell King - ARM Linux escribi?:
> On Wed, Sep 09, 2015 at 02:28:53PM -0300, Ariel D'Alessandro wrote:
>> Doing a bisect I've observed that regression appears to be caused by:
>>
>> commit 1eef5d2f1b461c120bcd82077edee5ec706ac53b
>> Author: Russell King <rmk+kernel@arm.linux.org.uk>
>> Date:   Wed Aug 19 21:23:48 2015 +0100
>>
>>     ARM: domains: switch to keeping domain value in register
>>
>>
>> Stacktrace paste below.
>>
>> [    0.171071] Unhandled exception: IPSR = 00000006 LR = fffffff1
> 
> This looks to be ARMv7M, which is nommu...  I guess what's causing this
> is this change in arch/arm/kernel/process.c:
> 
> +       /*
> +        * Copy the initial value of the domain access control register
> +        * from the current thread: thread->addr_limit will have been
> +        * copied from the current thread via setup_thread_stack() in
> +        * kernel/fork.c
> +        */
> +       thread->cpu_domain = get_domain();
> +
> 
> which probably needs to be #ifdef'd out for !MMU.  Can you try adding:
> 
> #ifndef CONFIG_MMU

I think you meant #ifdef CONFIG_MMU.

> ...
> #endif
> 
> around that please?  Thanks.
> 

Yeah, that works!

Added:

#ifdef CONFIG_MMU
...
#endif

around that code block and it booted.

Thanks,

-- 
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar

  reply	other threads:[~2015-09-09 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <55F06797.3060706@gmail.com>
     [not found] ` <55F06C55.5070205@vanguardiasur.com.ar>
2015-09-09 17:52   ` ARM: domains: Possible regression in v7-M Russell King - ARM Linux
2015-09-09 18:25     ` Ariel D'Alessandro [this message]
2015-09-09 20:24       ` Russell King - ARM Linux
2015-09-09 22:06         ` Ariel D'Alessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F079A5.1010501@vanguardiasur.com.ar \
    --to=ariel@vanguardiasur.com.ar \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox